[cinder] Review of tiny patch to add Ceph RBD fast-diff to cinder-backup

Brian Rosmaita rosmaita.fossdev at gmail.com
Tue Feb 23 21:21:59 UTC 2021

On 2/23/21 12:08 PM, Christian Rohmann wrote:
> Hey Jay, all,
> On 18/02/2021 11:43, Christian Rohmann wrote:
>> After some initial feedback, which I hopefully all fixed in my updated 
>> patchset, the review of 
>> (https://review.opendev.org/c/openstack/cinder/+/766856/)
>> has stalled.
>> Is there anything I would need to do to ask for this patch to be 
>> considered for a merge?
> Thanks for giving my patchset a +2.
> I am now wondering what else is required for this to be merged to the 
> next release?
> Do I need to find another reviewer, do I need to add it to some list or 
> will this get merged automatically?

We'll discuss this at tomorrow's (wednesday 24 Feb) cinder meeting. 
There is support for your patch, but maybe we shouldn't add a config 
option but should just do the fast diff by default if the array supports 
it and fall back to current behavior otherwise.

But to answer your question, you would need another +2 on the patch 
before it can be approved; once it's approved, it merges automatically 
(more or less).

> Regards
> Christian

More information about the openstack-discuss mailing list