[all][infra] CI test result table in the new gerrit review UI

Bogdan Dobrelya bdobreli at redhat.com
Mon Nov 30 14:01:14 UTC 2020


Hi stackers,

Until we have that pretty formatter for CI results, here's [0] a quick 
script instead. It queries Zuul CI comments by a given Gerrit SSH login 
and a patch set number, and colorizes it in your console outputs.

PS. I'm sorry for top posting.

[0] https://gist.github.com/bogdando/ed345b1f974c8e97edd33b61e7bf8158

> On Thu, 2020-11-26 at 17:30 +0000, Tristan Cacqueray wrote:
>> On Thu, Nov 26, 2020 at 15:59 Sean Mooney wrote:
>> > On Thu, 2020-11-26 at 15:19 +0000, Jeremy Stanley wrote:
>> > > On 2020-11-26 15:10:09 +0000 (+0000), Tristan Cacqueray wrote:
>> > > [...]
>> > > > Here is a CR to add the test result table back in the new gerrit UI:
>> > > > 
>> > > >   https://review.opendev.org/c/opendev/system-config/+/763891
>> > > > 
>> > > > This new implementation uses the javascript plugin extension API.
>> > > 
>> > > Thanks--that was quick work!
>> 
>> You're welcome :)
>> 
>> > is that going to be moved to the zuul org in opendev as a part of the zuul projects
>> > deliverables.
>> > 
>> > i kind of think it makes sne to develop it there rather then on the rdo gerrit instance.
>> > 
>> 
>> I'd be happy to move the project to the opendev gerrit.
>> 
>> > looking at the impleation it does not look like this owrks teh ssame way by parsing the comment
>> > https://softwarefactory-project.io/cgit/software-factory/zuul-results-gerrit-plugin/tree/src/ZuulResultsPlugin.re#n115
>> > 
>> 
>> That is correct, this is using the Gerrit Js plugin api, which let you
>> register a `showChange` callback, which is called with the change info
>> https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info
>> 
>> Thus no need to hack through the dom to get the comments.
>> 
>> Note that the gerrit related code is in another project here:
>>   https://softwarefactory-project.io/cgit/software-factory/re-gerrit/
>> 
>> > will this just show the results form zuul. it need to pars all the comments form the third party cis too.
>> > basicaly you need to parse all coment form a author that end isn CI and comments form zuul
>> 
>> It should do that already, though I haven't tested it with real data. I
>> guess the next step would be to enable such plugin on review-dev.
> so the author regular expression is only looking for zuul 
> https://softwarefactory-project.io/cgit/software-factory/re-gerrit/tree/src/CI.re#n41
> 
> so it lookes liek you would need to refactor that slightly to match comments form autors that end in ci too.
> 
> each CI systems comemtn then need have there won tabel section with the job results for that ci to mimic the same behavior
> we had in the old ui.
> 
> 
>> 
>> Cheers,
>> -Tristan

-- 
Best regards,
Bogdan Dobrelya,
Irc #bogdando




More information about the openstack-discuss mailing list