Open Stack

On Thu, Nov 26, 2020 at 05:57, Sorin Sbarnea <ssbarnea at redhat.com> 
wrote:
> Thanks! i works!
> 
> tMaybe now you can propose a CR to update the old script that no 
> longer worked?
> https://opendev.org/x/coats/src/branch/master/coats/openstack_gerrit_zuul_status.user.js#bypass=true

Sorry, I have no intention to do a full update on the original script. 
As far as I remember the old gerrit CI table did a lot more than what I 
hacked together and I have not enough time and knowledge to cover that. 
Also I'm not sure how the above script relates the solution in the old 
gerrit that was injected server side instead of injected from the 
client side.

> 
> There is one example where it does not play very nice due to lots of 
> changes sharing the same topic:
> https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/734217

What I see here is that there is a lot of related changes and the table 
is added at the end of the long list. But overall it works for me on 
this patch too. What is your specific problem?

Cheers,
gibi

> 
> Probably you can just replace the script, but I would bother to 
> increase the versioning because once we merge it, existing users may 
> be able to detect an update.
> 
> PS. Add me as reviewer.
> --
> /sorin
> 
> 
> On 26 Nov 2020 at 13:00:01, Lucio Seki <lucioseki at gmail.com> wrote:
>> Thanks a lot Balázs!
>> 
>> I minified [0] the script and put it in a bookmarklet [1]. It works 
>> like a charm [2] :-)
>> 
>> Lucio
>> 
>> [0] https://javascript-minifier.com/
>> [1] 
>> https://superuser.com/questions/279107/add-a-bookmarklet-in-google-chrome/1341468#1341468
>> [2] https://imgur.com/a/iy5jPIn
>> 
>> On Thu, 26 Nov 2020 at 09:42, Balázs Gibizer 
>> <balazs.gibizer at est.tech> wrote:
>>> Hi,
>>> 
>>>  I understand that adapting the old CI test result table to the new
>>>  gerrit review UI is not a simple task. As a temporary measure I 
>>> hacked
>>>  together a tampermonkey user script[1] that does a limited version 
>>> of
>>>  the CI table injection from the browser side. I tested it with 
>>> recent
>>>  chrome and firefox. Let me know if you have problems with it and 
>>> I'll
>>>  try to help. Also feel free to adapt it to your own needs.
>>> 
>>> 
>>>  Cheers,
>>>  gibi
>>> 
>>>  [1] 
>>> https://gist.github.com/gibizer/717e0cb5b0da0d60d5ecf1e18c0c171a
>>> 
>>> 
>>>