Upcoming pip changes - stop installing test-requirements in devstack

Sean Mooney smooney at redhat.com
Sat Mar 28 18:57:38 UTC 2020

On Fri, 2020-03-27 at 14:24 -0500, Monty Taylor wrote:
> Heya,
> Recently we had to revert a change to devstack that ran pip check. This is a recommendation from the pip team to
> verify that upcoming addition of a depsolver to pip isn’t going to break us. Well - it is going to break us.
> The reason it’s going to break us is that we don’t apply constraints to linters (so that projects can deal with those
> at their own rate) BUT - we install every project’s test-requirements.txt (containing the linters) when we run
> devstack. That means we uninstall and reinstall flake8 at different versions over and over again - and the final state
> is not one that is completely consistent.
> I’ve pushed up this:
> https://review.opendev.org/#/c/715469/
> Which is a patch to stop installing test-requirements in devstack. Realistically we should not need to install this in
> devstack. Devstack is installing the software which does not need test-requirements - and then we test it with tempest
> which has its own set of requirements. As a side benefit, devstack is quicker and none of the non-voting jobs on
> devstack fail now.

i brought up the topic of stoping installing test-requirement in the past as it has caused issue before so im happy
to see this change going forward :)
> It’s possible this change could impact people using devstack as a base for single-project functional tests - so it’s
> worth being careful with. But I think we should get it done and then re-add the pip check as a verification that we’re
> not going to get broken this summer.
> Monty

More information about the openstack-discuss mailing list