Upcoming pip changes - stop installing test-requirements in devstack

Radosław Piliszek radoslaw.piliszek at gmail.com
Sat Mar 28 08:34:39 UTC 2020


Hiya,

it's now going in.

Dev Folks: if it breaks jobs and you need assistance, please respond
to this thread or ping on #openstack-qa

-yoctozepto

pt., 27 mar 2020 o 20:33 Monty Taylor <mordred at inaugust.com> napisał(a):
>
> Heya,
>
> Recently we had to revert a change to devstack that ran pip check. This is a recommendation from the pip team to verify that upcoming addition of a depsolver to pip isn’t going to break us. Well - it is going to break us.
>
> The reason it’s going to break us is that we don’t apply constraints to linters (so that projects can deal with those at their own rate) BUT - we install every project’s test-requirements.txt (containing the linters) when we run devstack. That means we uninstall and reinstall flake8 at different versions over and over again - and the final state is not one that is completely consistent.
>
> I’ve pushed up this:
>
> https://review.opendev.org/#/c/715469/
>
> Which is a patch to stop installing test-requirements in devstack. Realistically we should not need to install this in devstack. Devstack is installing the software which does not need test-requirements - and then we test it with tempest which has its own set of requirements. As a side benefit, devstack is quicker and none of the non-voting jobs on devstack fail now.
>
> It’s possible this change could impact people using devstack as a base for single-project functional tests - so it’s worth being careful with. But I think we should get it done and then re-add the pip check as a verification that we’re not going to get broken this summer.
>
> Monty



More information about the openstack-discuss mailing list