Open Stack

Hi,

I filed a bug to track the said connection leak problem[1] while I
implemented a short-term workaround[2]
for our py2 tests. Now we see the py2 testing has passed without any
failures[3].

 [1] https://bugs.launchpad.net/python-swiftclient/+bug/1873435
 [2] https://review.opendev.org/#/c/720646/
 [3] https://review.opendev.org/#/c/720314/

If nobody has objections about the current direction, I'll start merging
revert changes(and some fixes to run tests on py2)

https://review.opendev.org/#/q/topic:py27+project:openstack/storlets+status:open

Thank you,
Takashi


On Fri, Apr 17, 2020 at 4:49 PM Takashi Kajinami <tkajinam at redhat.com>
wrote:

> Hi Ghanshyam,
>
> Thanks for your suggestion, and sorry for keeping you waiting.
>
> Reversions to enable py2 tests are mostly done[1], but currently we are
> hitting a connection leak issues
> with swiftclient 3.9.0 on Python2.7 (I'll file a bug later).
> Because usage swiftclient 3.9.0 is forced by upper-constrants.txt, now I'm
> trying to implement
> some workaround to make sure we install 3.8.1 in func tests tox
> environment.
>  [1]
> https://review.opendev.org/#/q/status:open+project:openstack/storlets+branch:master+topic:py27
>
> I'll let you know once I complete this work, but please allow us to take
> some time
> to find possible solutions so far.
>
> Thank you,
> Takashi
>
> On Thu, Apr 16, 2020 at 12:35 AM Ghanshyam Mann <gmann at ghanshyammann.com>
> wrote:
>
>>  ---- On Wed, 15 Apr 2020 09:41:07 -0500 Takashi Kajinami <
>> tkajinam at redhat.com> wrote ----
>>  > Hi Ghanshyam,
>>  >
>>  > > > Sorry to be late to raise this up, but I'd like to request to
>> postpone completion of "Dropping Python2.7 Support" work in Storlets during
>> this cycle.
>>  > >  > Storlets is heavily dependent on swift and swift won't drop
>> python 2.7 support during this cycle.This means that we still expect some
>> users who want to run storlets with their swiftrunning on python2 during
>> Ussuri.
>>  > >
>>  > > Yeah, this request is too late when we almost done to drop the py2
>> except swift. You should have brought this during planning phase.
>>  > > But close interaction with swift and the use case you described make
>> sense too.Again so sorry for our late request.We initially thought that we
>> would require users to use python3 to if they want to have Storlets with
>> Swift,but we found that concerns regarding possible known issues with
>> python3 in swift which Kota pointed out
>>  > while discussing this in irc.
>>  > IPython3 should be our first option, so we won't add python2 tests
>> back.
>>  > However we are still looking for the possibility to keep python2
>> support mark so thatusers can run Storlets with python2 if they still need
>> to run swift because of its known issues.We haven't dropped any
>> compatibility codes for python2 yet, so adding the partial revert[1]
>> toremove restrictions for Python3 should let operators use Storlets with
>> python2 at their own risk. [1] https://review.opendev.org/#/c/720131/2
>>  > > Before I check the possible options, I would like to know is there
>> any OpenStack dependency (library or any other project) in Storlets for
>> python2?From a functional perspective, Storlets depends on the same
>> packages as swift does.(Precisely speaking it uses a subset of swift's
>> dependencies)It doesn't depend on either any libraries like oslo.foo or
>> other projects.
>>  > The packages listed in test-requirements are all mostly for functional
>> tests, andused to prepare required resources in keystone, swift, etc.
>>  >
>>  > I'd really appreciate your help and consideration about this topic.
>>
>> Thanks, Takashi for explaining, it looks good to me as this is much
>> closure to swift in terms of deps and use case.
>> I am ok with keeping py2 support but I think saying py2 is supported
>> without testing, is very confusing and risky.
>> Instead of breaking users for untested-supported things, we should either
>> test it or drop completely.
>> In that case, can you also revert the patch dropping the py2
>> testing/requirements? which is this -
>> https://review.opendev.org/#/c/692277/5
>>
>> After that, I will propose adding the Storlets in
>> python2-keeping-projects list in goal doc.
>>
>> -gmann
>>
>>
>>
>>  > Thank you,Takashi
>>  >
>>  > On Wed, Apr 15, 2020 at 10:53 PM Ghanshyam Mann <
>> gmann at ghanshyammann.com> wrote:
>>  >
>>  >
>>  > --
>>  > ----------Takashi Kajinami
>>  > Senior Software Maintenance Engineer
>>  > Customer Experience and Engagement
>>  > Red Hate-mail: tkajinam at redhat.com
>>  > ---- On Wed, 15 Apr 2020 02:30:08 -0500 Takashi Kajinami <
>> tkajinam at redhat.com> wrote ----
>>  >  > Hi,
>>  >  >
>>  >  > Sorry to be late to raise this up, but I'd like to request to
>> postponecompletion of "Dropping Python2.7 Support" work in Storlets during
>> this cycle.
>>  >  > Storlets is heavily dependent on swift and swift won't drop python
>> 2.7 support during this cycle.This means that we still expect some users
>> who want to run storlets with their swiftrunning on python2 during Ussuri.
>>  >
>>  > Yeah, this request is too late when we almost done to drop the py2
>> except swift. You should have brought this during planning phase.
>>  > But close interaction with swift and the use case you described make
>> sense too.
>>  >
>>  > Before I check the possible options, I would like to know is there any
>> OpenStack dependency (library or any other project) in Storlets for python2?
>>  >
>>  > Few I can see in test requirements need few[1].
>>  >
>>  > [1]
>> https://github.com/openstack/storlets/blob/a8f1fce69ab236314ae62316482da2f11fe19865/test-requirements.txt
>>  >
>>  > -gmann
>>  >
>>  >  >
>>  >  > Currently we've completed all python3 compatibility work, and py2
>> tests are already dropped.However we would like to postpone marking
>> storlets as python3 only(and dropping all py2-3 compatibility codes)
>>  >  > so that we don't prohibit users from using it in swift with python2.
>>  >  >
>>  >  > See the following patch to remove python3 only mark at the
>> moment.(It was initially added, but we want to revert it)
>>  >  >  [1] https://review.opendev.org/#/c/720131/2
>>  >  > Thank you,Takashi
>>  >  > --
>>  >  > ----------Takashi Kajinami
>>  >  > Senior Software Maintenance Engineer
>>  >  > Customer Experience and Engagement
>>  >  > Red Hate-mail: tkajinam at redhat.com
>>  >  >
>>  >
>>  >
>>
>>
>
> --
> ----------
> Takashi Kajinami
> Senior Software Maintenance Engineer
> Customer Experience and Engagement
> Red Hat
> e-mail: tkajinam at redhat.com
>
>

-- 
----------
Takashi Kajinami
Senior Software Maintenance Engineer
Customer Experience and Engagement
Red Hat
e-mail: tkajinam at redhat.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20200417/dc3401d1/attachment.html>