[zun][zun-ui][horizon] Request code review for a breaking fix

Akihiro Motoki amotoki at gmail.com
Tue Nov 26 13:22:20 UTC 2019

Sorry for late. While the patch has been approved by other horizon
cores, I have a question which blocks me for long.

The proposed code is related to the serial console support and AFAIK
it was introduced to support the serial console of nova servers.
Perhaps Hongbin confirms it works with zun instance, but how can we
test it with nova servers with serial consoles (ironic instances?)?

Many developers add features to horizon but they don't leave enough
information on how to test them, so the current horizon team is
struggling to know how to test :-(
That's one reason that reviews for non-popular areas tend to take time
for long.... I wonder how we can improve this situation.....


On Tue, Nov 26, 2019 at 1:13 PM Hongbin Lu <hongbin034 at gmail.com> wrote:
> Hi Horizon folks,
> We have an issue that needs to be fixed at horizon side. Please check this bug:
> https://bugs.launchpad.net/zun-ui/+bug/1847889
> We propose a fix on Horizon but the patch hasn't been moved forward for a while. Would I ask for a code review for the patch https://review.opendev.org/#/c/688290/ ? Without the fix, our horizon plugin couldn't work correctly.
> Best regards,
> Hongbin

More information about the openstack-discuss mailing list