Are most grenade plugin projects doing upgrades wrong?
gmann at ghanshyammann.com
Fri Jun 14 17:17:32 UTC 2019
---- On Fri, 14 Jun 2019 01:13:33 +0900 Elõd Illés <elod.illes at ericsson.com> wrote ----
> Actually, if you check  and , they seemingly check out master, but
> just below the linked line like 20 lines, there's a 'git show --oneline'
> and 'head -1' which shows that the branch is clearly stable/stein. So it
> seems there's no need for explicit branch settings in ... but I
> haven't found the code lines which cause this behavior, yet...
yeah, it seems it did checkout stein version. But from log it is not clear where exactly
/opt.stack/old/watcher dir is being cloned from stein? this is the first clone I am seeing in log.
I checked for designate grenade job on stein and rocky branch and they also seem to
clone the correct base designate .
Are we missing the log somewhere where the correct base is cloned?
> On 2019. 06. 13. 15:45, Matt Riedemann wrote:
> > While fixing how the watcher grenade plugin is cloning the watcher
> > repo for the base (old) side  to hard-code from stable/rocky to
> > stable/stien, I noticed that several other projects with grenade
> > plugins aren't actually setting a stable branch when cloning the
> > plugin for the old side . So I tried removing the stable/stein
> > branch from the base plugin clone in watcher  and grenade cloned
> > from master for the base (old) side . Taking designate as an
> > example, I see the same thing happening for it's grenade run .
> > Is there something I'm missing here or are most of the openstack
> > projects running grenade via plugin actually just upgrading from
> > master to master rather than n-1 to master?
> >  https://review.opendev.org/#/c/664610/1/devstack/upgrade/settings
> > 
> > http://codesearch.openstack.org/?q=base%20enable_plugin&i=nope&files=&repos=
> >  https://review.opendev.org/#/c/664610/2/devstack/upgrade/settings
> > 
> > http://logs.openstack.org/10/664610/2/check/watcher-grenade/ad2e068/logs/grenade.sh.txt.gz#_2019-06-12_19_19_36_874
> > 
> > http://logs.openstack.org/47/662647/6/check/designate-grenade-pdns4/0b8968f/logs/grenade.sh.txt.gz#_2019-06-09_23_10_03_034
> > --
> > Thanks,
> > Matt
More information about the openstack-discuss