[openstack-dev] [oslo.db] [all] please DO NOT IMPORT from oslo_db.tests.* ! projects doing this need to revert ASAP

Andrey Kurilin andr.kurilin at gmail.com
Mon Feb 19 16:22:15 UTC 2018


Imo, it creates more problems than profits. If someone wants to change the
code and run tests -> use git repositories. Prepared python package is not
about this.

2018-02-19 17:57 GMT+02:00 Doug Hellmann <doug at doughellmann.com>:

> IIRC we started doing that so that consumers building their own packages
> can run the tests for the packages easily. I don't know how many people
> are doing that, and apparently at least some downstream consumers aren't
> packaging everything anyway so they couldn't run those tests.
>
> Excerpts from Andrey Kurilin's message of 2018-02-19 17:39:11 +0200:
> > Can someone explain me the reason for including "tests" module into
> > packages?
> >
> > 2018-02-19 17:00 GMT+02:00 Michael Bayer <mbayer at redhat.com>:
> >
> > > Hi list -
> > >
> > > Apparently Cinder was misled by my deprecations within the
> > > oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> > > in https://review.openstack.org/#/c/522290/ the assumption was made
> > > that these should be imported from oslo_db.tests.sqlalchemy.    This
> > > is an immense mistake on my part that I did not expect people to go
> > > looking for the same names elsewhere in private packages and now we
> > > have a serious downstream issue as these modules are not packaged, as
> > > well as the possibility that the oslo_db.tests. package is now locked
> > > in time and I have to add deprecations there also.
> > >
> > > If anyone knows of projects (or feels like helping me search) that are
> > > importing *anything* from oslo_db.tests these must be reverted ASAP.
> > >
> > > ____________________________________________________________
> ______________
> > > OpenStack Development Mailing List (not for usage questions)
> > > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:
> unsubscribe
> > > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > >
> >
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Best regards,
Andrey Kurilin.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180219/8456c3b3/attachment.html>


More information about the OpenStack-dev mailing list