[openstack-dev] [nova] Heads up for out-of-tree drivers: supports_recreate -> supports_evacuate

Matthew Booth mbooth at redhat.com
Thu Apr 19 16:06:37 UTC 2018


On 19 April 2018 at 15:33, Jay Pipes <jaypipes at gmail.com> wrote:
> On 04/19/2018 09:15 AM, Matthew Booth wrote:
>>
>> We've had inconsistent naming of recreate/evacuate in Nova for a long
>> time, and it will persist in a couple of places for a while more.
>> However, I've proposed the following to rename 'recreate' to
>> 'evacuate' everywhere with no rpc/api impact here:
>>
>> https://review.openstack.org/560900
>>
>> One of the things which is renamed is the driver 'supports_recreate'
>> capability, which I've renamed to 'supports_evacuate'. The above
>> change updates this for in-tree drivers, but as noted in review this
>> would impact out-of-tree drivers. If this might affect you, please
>> follow the above in case it merges.
>
>
> I have to admit, Matt, I'm a bit confused by this. I was under the
> impression that we were trying to *remove* uses of the term "evacuate" as
> much as possible because that term is not adequately descriptive of the
> operation and terms like "recreate" were more descriptive?

I'm ambivalent, tbh, but I think it's better to pick one. I thought
we'd picked 'evacuate' based on the TODOs from Matt R:

http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n2985
http://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py#n3093

Incidentally, this isn't at all core to what I'm working on, but I'm
about to start poking it and thought I'd tidy up as I go (as is my
wont). If there's discussion to be had I don't mind dropping this and
moving on.

Matt
-- 
Matthew Booth
Red Hat OpenStack Engineer, Compute DFG

Phone: +442070094448 (UK)



More information about the OpenStack-dev mailing list