[openstack-dev] [neutron][dynamic routing] RYU Breaks lower constraints

Slawomir Kaplonski skaplons at redhat.com
Tue Apr 17 06:55:35 UTC 2018


Hi,

Just for information to all who sends patches for Neutron.
Patch [1] is now merged so if in Your patch lower-constraints job is still failing with error like in this thread, please rebase Your patch on top of [1] instead of just rechecking which probably will not help.

[1] https://review.openstack.org/#/c/561579/

> Wiadomość napisana przez Slawomir Kaplonski <skaplons at redhat.com> w dniu 16.04.2018, o godz. 12:41:
> 
> I just sent a patch to bump Ryu version in Neutron’s requirements to fix lower constraints job there also: https://review.openstack.org/#/c/561579/
> 
> 
>> Wiadomość napisana przez Gary Kotton <gkotton at vmware.com> w dniu 16.04.2018, o godz. 09:13:
>> 
>> Please see https://review.openstack.org/561443
>> 
>> On 4/16/18, 2:31 AM, "IWAMOTO Toshihiro" <iwamoto at valinux.co.jp> wrote:
>> 
>>   On Sun, 15 Apr 2018 21:02:42 +0900,
>>   Gary Kotton wrote:
>>> 
>>> [1  <multipart/alternative (7bit)>]
>>> [1.1  <text/plain; utf-8 (base64)>]
>>> Hi,
>>> That sounds reasonable. I wonder if the RYU folk can chime in here.
>>> Thanks
>> 
>>   I don't fully understand the recent g-r change yet, but
>>   I guess neutron-dynamic-routing should  also have ryu>=4.24.
>>   I'll check this tommorrow.
>> 
>>> From: Akihiro MOTOKI <amotoki at gmail.com>
>>> Reply-To: OpenStack List <openstack-dev at lists.openstack.org>
>>> Date: Sunday, April 15, 2018 at 12:43 PM
>>> To: OpenStack List <openstack-dev at lists.openstack.org>
>>> Subject: Re: [openstack-dev] [neutron][dynamic routing] RYU Breaks lower constraints
>>> 
>>> Gary,
>>> 
>>> I think this is caused by the recent pip change and pip no longer cannot import pip from code. The right solution seems to bump the minimum version of ryu.
>>> 
>>> Thought?
>>> 
>>> http://lists.openstack.org/pipermail/openstack-dev/2018-March/128939.html
>>> 
>>> Akihiro
>>> 
>>> 2018/04/15 午後6:06 "Gary Kotton" <gkotton at vmware.com<mailto:gkotton at vmware.com>>:
>>> Hi,
>>> It seems like ther RYU import is breaking the project:
>>> 
>>> 
>>> 2018-04-15 08:41:34.654681<http://logs.openstack.org/43/561443/3/check/openstack-tox-lower-constraints/087c168/job-output.txt.gz#_2018-04-15_08_41_34_654681> | ubuntu-xenial | b'--- import errors ---\nFailed to import test module: neutron_dynamic_routing.tests.unit.services.bgp.driver.ryu.test_driver\nTraceback (most recent call last):\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/unittest2/loader.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/unittest2/loader.py>", line 456, in _find_test_path\n    module = self._get_module_from_name(name)\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/unittest2/loader.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/unittest2/loader.py>", line 395, in _get_modu
>>    le_from_name\n    __import__(name)\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/neutron_dynamic_routing/tests/unit/services/bgp/driver/ryu/test_driver.py<http://git.openstack.org/openstack/neutron-dynamic-routing/neutron_dynamic_routing/tests/unit/services/bgp/driver/ryu/test_driver.py>", line 21, in <module>\n    from ryu.services.protocols.bgp import bgpspeaker\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/services/protocols/bgp/bgpspeaker.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/services/protocols/bgp/bgpspeaker.py>", line 21, in <module>\n    from ryu.lib.packet.bgp import (\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/__init__.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/l
>>    ower-constraints/lib/python3.5/site-packages/ryu/lib/packet/__init__.py>", line 6, in <module>\n    from . import (ethernet, arp, icmp, icmpv6, ipv4, ipv6, lldp, mpls, packet,\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/ethernet.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/ethernet.py>", line 18, in <module>\n    from . import vlan\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/vlan.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/vlan.py>", line 21, in <module>\n    from . import ipv4\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/ipv4.py<h
>>    ttp://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/ipv4.py>", line 23, in <module>\n    from . import tcp\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/tcp.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/tcp.py>", line 24, in <module>\n    from . import bgp\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/bgp.py<http://git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/lib/packet/bgp.py>", line 52, in <module>\n    from ryu.utils import binary_str\n  File "/home/zuul/src/git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/utils.py<http://
>>    git.openstack.org/openstack/neutron-dynamic-routing/.tox/lower-constraints/lib/python3.5/site-packages/ryu/utils.py>", line 23, in <module>\n    from pip import req as pip_req\nImportError: cannot import name \'req\'\n'
>>> 
>>> Any suggestions?
>>> Thanks
>>> Gary
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe<http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>> 
>>> [1.2  <text/html; utf-8 (base64)>]
>>> [2  <text/plain; utf-8 (base64)>]
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> 
>>   __________________________________________________________________________
>>   OpenStack Development Mailing List (not for usage questions)
>>   Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>   http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> 
>> 
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
>> Best regards
> Slawek Kaplonski
> skaplons at redhat.com
> 

— 
Best regards
Slawek Kaplonski
skaplons at redhat.com




More information about the OpenStack-dev mailing list