[openstack-dev] Garbage patches for simple typo fixes

David Moreau Simard dms at redhat.com
Fri Sep 22 04:43:47 UTC 2017

Wow, Matt, that's excellent timing.
Day for day, an exact year after the last thread of this kind [1].

Thanks for speaking up, I didn't want to it'd seem like encouraging a
stereotype or prejudice towards certain kind of contributions (or
contributors) but I've also been rolling my eyes a lot recently.
It does look like those users are just seeking to pad statistics, but
this isn't the first time this kind of topic comes up.

Some other contributors with similar patterns:

- https://review.openstack.org/#/q/author:%255E.*unionpay.*
- https://review.openstack.org/#/q/author:%255E.*fiberhome.*
- https://review.openstack.org/#/q/author:%255E.*sina.*

There are some thoughts in the thread from last year but I don't think
any concrete measures were put in place to encourage better and more
meaningful contributions.

[1]: http://lists.openstack.org/pipermail/openstack-dev/2016-September/104173.html

David Moreau Simard
Senior Software Engineer | OpenStack RDO

dmsimard = [irc, github, twitter]

On Thu, Sep 21, 2017 at 10:21 PM, Matt Riedemann <mriedemos at gmail.com> wrote:
> I just wanted to highlight to people that there seems to be a series of
> garbage patches in various projects [1] which are basically doing things
> like fixing a single typo in a code comment, or very narrowly changing http
> to https in links within docs.
> Also +1ing ones own changes.
> I've been trying to snuff these out in nova, but I see it's basically a
> pattern widespread across several projects.
> This is the boilerplate comment I give with my -1, feel free to employ it
> yourself.
> "Sorry but this isn't really a useful change. Fixing typos in code comments
> when the context is still clear doesn't really help us, and mostly seems
> like looking for padding stats on stackalytics. It's also a drain on our CI
> environment.
> If you fixed all of the typos in a single module, or in user-facing
> documentation, or error messages, or something in the logs, or something
> that actually doesn't make sense in code comments, then maybe, but this
> isn't one of those things."
> I'm not trying to be a jerk here, but this is annoying to the point I felt
> the need to say something publicly.
> [1] https://review.openstack.org/#/q/author:%255E.*inspur.*
> --
> Thanks,
> Matt
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list