[openstack-dev] [tc][nova][mogan] How to show respect to the original authors?

Zhenguo Niu niu.zglinux at gmail.com
Wed Sep 20 08:20:26 UTC 2017


Hi all,

I'm from Mogan team, we copied some codes/frameworks from Nova since we
want to be a Nova with a bare metal specific API.
About why reinventing the wheel, you can find more informations here [1].

I would like to know what's the decent way to show our respect to the
original authors we copied from.

After discussing with the team, we plan to do some improvements as below:

1. Adds some comments to the beginning of such files to indicate that they
leveraged the implementation of Nova.

https://github.com/openstack/mogan/blob/master/mogan/baremetal/ironic/driver.py#L19
https://github.com/openstack/mogan/blob/master/mogan/console/websocketproxy.py#L17-L18
https://github.com/openstack/mogan/blob/master/mogan/consoleauth/manager.py#L17
https://github.com/openstack/mogan/blob/master/mogan/engine/configdrive.py#L17
https://github.com/openstack/mogan/blob/master/mogan/engine/metadata.py#L18
https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18
https://github.com/openstack/mogan/blob/master/mogan/objects/aggregate.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/keypair.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/server_fault.py#L17
https://github.com/openstack/mogan/blob/master/mogan/objects/server_group.py#L17
https://github.com/openstack/mogan/blob/master/mogan/scheduler/client/report.py#L17
https://github.com/openstack/mogan/blob/master/mogan/scheduler/filter_scheduler.py#L17

2. For the changes we follows what nova changed, should reference to the
original authors in the commit messages.


Please let me know if there are something else we need to do or there are
already some existing principles we can follow, thanks!



[1] https://wiki.openstack.org/wiki/Mogan


-- 
Best Regards,
Zhenguo Niu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170920/161b4702/attachment.html>


More information about the OpenStack-dev mailing list