[openstack-dev] Removing internet access from unit test gates

Jeremy Stanley fungi at yuggoth.org
Tue Nov 21 15:04:44 UTC 2017

On 2017-11-21 09:28:20 +0100 (+0100), Thomas Goirand wrote:
> The only way that I see going forward, is having internet access
> removed from unit tests in the gate, or probably just the above
> variables set.

Historically, our projects hadn't done a great job of relegating
their "unit test" jobs to only run unit tests, and had a number of
what would be commonly considered functional tests mixed in. This
has improved in recent years as many of those projects have created
separate functional test jobs and are able to simplify their unit
test jobs accordingly, so this may be more feasible now than it was
in the past.

Removing network access from the machines running these jobs won't
work, of course, because our job scheduling and execution service
needs to reach them over the Internet to start jobs, monitor
progress and collect results. As you noted, faking Python out with
envvars pointing it at nonexistent HTTP proxies might help at least
where tests attempt to make HTTP(S) connections to remote systems.
The Web is not all there is to the Internet however, so this
wouldn't do much to prevent use of remote DNS, NTP, SMTP or other
non-HTTP(S) protocols.

The biggest wrinkle I see in your "proxy" idea is that most of our
Python-based projects run their unit tests with tox, and it will use
pip to install project and job dependencies via HTTPS prior to
starting the test runner. As such, any proxy envvar setting would
need to happen within the scope of tox itself so that it will be
able to set up the virtualenv prior to configuring the proxy vars
for the ensuing tests. It might be easiest for you to work out the
tox.ini modification on one project (it'll be self-testing at least)
and then once the pilot can be shown working the conversation with
the community becomes a little easier.
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20171121/088654f8/attachment.sig>

More information about the OpenStack-dev mailing list