Open Stack

On Thu, Nov 16, 2017 at 1:17 PM, Matt Riedemann <mriedemos at gmail.com> wrote:

> On 11/16/2017 12:15 PM, Matt Riedemann wrote:
>
>> On 11/16/2017 9:58 AM, Jeremy Stanley wrote:
>>
>>> On 2017-11-16 15:17:58 +0900 (+0900), Takashi Natsume wrote:
>>>
>>>> In nova-specs project, there is an 'openstack-tox-py27' job (in
>>>> Zuul check or Zuul gate). The job checks whether spec files comply
>>>> with the template or not, line length, etc. But there are cases
>>>> that the job is not executed even if a spec file is added or
>>>> modified.
>>>>
>>> [...]
>>>
>>> Most projects want to have their unit test jobs skipped on changes
>>> which only alter documentation. The nova-specs repo is unusual in
>>> that it's attempting to leverage a unit testing job to validate
>>> documentation formatting rather than the sorts of docs linters other
>>> projects rely on.
>>>
>>>
>>>
>>> __________________________________________________________________________
>>>
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe: OpenStack-dev-request at lists.op
>>> enstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>>
>> Yeah, in other words, the job definition skips the files that we care
>> about in nova-specs:
>>
>> https://github.com/openstack-infra/openstack-zuul-jobs/blob/
>> 00168bf82cf4a13ac6339736667dd532eeeff4e9/zuul.d/jobs.yaml#L238
>>
>> So we'll probably need to change the definition of the nova-specs py27
>> job to run these linter type tests in the pep8 run.
>>
>>
> By the way, it looks like neutron-specs and cinder-specs are going to have
> the same problem.
>
>
> --
>
> Thanks,
>
> Matt
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>


We had a similar problem with ironic-specs, and ended up going with
openstack-tox-linters because we do doc8 and some unit tests that do
fancy-schmancy (i.e. I don't remember what) checking :)

--ruby
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20171116/97d75d55/attachment.html>