<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Nov 16, 2017 at 1:17 PM, Matt Riedemann <span dir="ltr"><<a href="mailto:mriedemos@gmail.com" target="_blank">mriedemos@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 11/16/2017 12:15 PM, Matt Riedemann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 11/16/2017 9:58 AM, Jeremy Stanley wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 2017-11-16 15:17:58 +0900 (+0900), Takashi Natsume wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In nova-specs project, there is an 'openstack-tox-py27' job (in<br>
Zuul check or Zuul gate). The job checks whether spec files comply<br>
with the template or not, line length, etc. But there are cases<br>
that the job is not executed even if a spec file is added or<br>
modified.<br>
</blockquote>
[...]<br>
<br>
Most projects want to have their unit test jobs skipped on changes<br>
which only alter documentation. The nova-specs repo is unusual in<br>
that it's attempting to leverage a unit testing job to validate<br>
documentation formatting rather than the sorts of docs linters other<br>
projects rely on.<br>
<br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________ <br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
</blockquote>
<br>
Yeah, in other words, the job definition skips the files that we care about in nova-specs:<br>
<br>
<a href="https://github.com/openstack-infra/openstack-zuul-jobs/blob/00168bf82cf4a13ac6339736667dd532eeeff4e9/zuul.d/jobs.yaml#L238" rel="noreferrer" target="_blank">https://github.com/openstack-i<wbr>nfra/openstack-zuul-jobs/blob/<wbr>00168bf82cf4a13ac6339736667dd5<wbr>32eeeff4e9/zuul.d/jobs.yaml#L2<wbr>38</a> <br>
<br>
So we'll probably need to change the definition of the nova-specs py27 job to run these linter type tests in the pep8 run.<br>
<br>
</blockquote>
<br></span>
By the way, it looks like neutron-specs and cinder-specs are going to have the same problem.<div class="HOEnZb"><div class="h5"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br></div><div class="gmail_extra"><br></div><div class="gmail_extra">We had a similar problem with ironic-specs, and ended up going with openstack-tox-linters because we do doc8 and some unit tests that do fancy-schmancy (i.e. I don't remember what) checking :)</div><div class="gmail_extra"><br></div><div class="gmail_extra">--ruby</div></div>