[openstack-dev] [elastic-recheck] Miscellaneous questions of potential Neutron interest

Matthew Treinish mtreinish at kortar.org
Tue Jan 31 19:04:58 UTC 2017


On Tue, Jan 31, 2017 at 10:38:58AM -0800, Ihar Hrachyshka wrote:
> Hi all,
> 
> we were looking at expanding usage of elastic-recheck in Neutron, and
> several questions popped up that we would like to ask.
> 
> 1. Are all jobs eligible for coverage with queries? The reason we ask
> is that there was some disagreement on whether all job runs are
> eligible, or e.g. gate queue job runs only. For example, in Neutron,
> we have fullstack and functional tests that are in check queue but not
> in gate queue. Can we still post queries for those jobs? Will e-r bot
> match against those queries?

The elastic recheck bot listens to all jobs, and we can add queries for
any gate failure. In the past we limited it to just dsvm jobs and just projects
in openstack/ namespace. But we haven't done either of those in a really long time,
the dsvm limitation was just for like the first month of the project.
> 
> 2. Review velocity is not stable in the project. Sometimes we get
> immediate reviews, sometimes not so much (the last one took me a month
> to land a query). It's important that new queries get timely feedback.
> Can we consider expanding core reviewer team to smoothen the process?
> If not, how can we make sure queries land in time?

Well there are really only 3 cores on the project, and if some of us aren't
working or are busy with other things the queue can get backed up and things
fall through the cracks. Although, fwiw new queries aren't a steady stream
either. We've gone months where just mriedem or me were the only people
pushing queries.

I'm totally in favor of expanding the review team, the issue here is that not
many people have stood up to start tackling reviews. The only reviews from
non-cores I normally see are people from a project team piling on to a query
for a bad gate bug they're hitting at the time. e-r queries aren't that hard
to review and there are just a few things we look for which are outlined here:
https://github.com/openstack-infra/elastic-recheck#queries
if people step up and start helping out with the review load we definitely can
expand the core team.


> 
> 3. I see some IRC channels have elastic-recheck bot reporting about
> identified failures in the channels. How can we add the bot to our
> channel?

This is a just specified in a config file:

https://github.com/openstack-infra/puppet-elastic_recheck/blob/master/files/recheckwatchbot.yaml#L1-L7

It's just no project (besides QA) has ever chosen to subscribe to irc
notifications before. There was discussion about it back when we first
introduced the bot, but it wasn't turned on because of concerns around channel
noise. (https://review.openstack.org/#/c/79123/ )

What the bot reports to irc is also configurable. So you can have it return
on failures for a particular project (or group of projects) and also only on
identified or unidentified failures.

Thanks,

Matt Treinish
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170131/294e439f/attachment.pgp>


More information about the OpenStack-dev mailing list