[openstack-dev] [neutron] Engine facade

Kevin Benton kevin at benton.pub
Tue Apr 4 10:18:15 UTC 2017


I worked with Gary on IRC and discovered that we aren't making use of the
flag added in [1], which makes adoption harder. I've proposed a patch to
neutron-lib[2] that should alleviate some of these issues.

1. https://bugs.launchpad.net/oslo.db/+bug/1664643
2. https://review.openstack.org/#/c/453063/

On Tue, Apr 4, 2017 at 3:11 AM, Anna Taraday <akamyshnikova at mirantis.com>
wrote:

> Hi!
>
> This errors does not mean that foreign key usage is broken. This means
> that there is a mess with transactions. As you paste small piece of trace
> it is hard to say why this happen, but during my work I saw such errors and
> resolve them. And probably you need to revisit your unit tests.
>
> Please, send me email directly with links for traces, does this happen on
> master branch, does it happen on one of your changes - it is hard to guess.
>
>
>
> On Tue, Apr 4, 2017 at 11:16 AM Gary Kotton <gkotton at vmware.com> wrote:
>
> Hi,
>
> The problem that we have is that any foreign key usage under transactions
> is now broken. An example of an exception that is raised is:
>
>
>
>     DBReferenceError: (sqlite3.IntegrityError) FOREIGN KEY constraint
> failed [SQL: u'INSERT INTO neutron_nsx_firewall_section_mappings
> (created_at, updated_at, neutron_id, nsx_id) VALUES (?, ?, ?, ?)']
> [parameters: ('2017-04-04 06:48:25.595118', None, '6a086bf1-b1c9-495f-bfca-810d6638e3fa',
> '2563cd05-edd9-4c7f-9708-857a129e2642')]
>
>
>
> This is a major refactor in the plugin (which I guess is part and parcel
> of rolling with the punches). I am just concerned if we are the only folks
> that have affected by this.
>
> Thanks
>
> Gary
>
>
>
> *From: *Gary Kotton <gkotton at vmware.com>
> *Reply-To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Date: *Monday, April 3, 2017 at 3:14 PM
>
>
> *To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Subject: *Re: [openstack-dev] [neutron] Engine facade
>
>
>
> Hi,
>
> We needed to make all of those changes to just get the plugin to pass unit
> tests and CI. We are still seeing lots of issues and need to look deeper.
> The façade changes have caused a lot of instability issues. I am not 100%
> sure why. Issues that we have seen:
>
> 1. object creation under a transaction broke
>
> 2. deleting DB entries under transaction also broke
>
> Thanks
>
> Gary
>
>
>
>
>
> *From: *Anna Taraday <akamyshnikova at mirantis.com>
> *Reply-To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Date: *Monday, April 3, 2017 at 11:53 AM
> *To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Subject: *Re: [openstack-dev] [neutron] Engine facade
>
>
>
> Hi!
>
> I'm a little confused change https://review.openstack.org/#/c/452539/ is
> about switching for new facade, does the master branch fails the same?
>
>
>
> On Mon, Apr 3, 2017 at 8:35 AM Gary Kotton <gkotton at vmware.com> wrote:
>
> Yes, sorry my bad for not adding it - http://logs.openstack.org/39/
> 452539/2/check/gate-vmware-nsx-python27-ubuntu-xenial/
> 14c019c/testr_results.html.gz
>
> Please see the test *test_create_port_dns_name*
>
> Thanks
>
> Gary
>
>
>
> *From: *Kevin Benton <kevin at benton.pub>
> *Reply-To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Date: *Monday, April 3, 2017 at 12:56 AM
> *To: *OpenStack List <openstack-dev at lists.openstack.org>
> *Subject: *Re: [openstack-dev] [neutron] Engine facade
>
>
>
> Do you have a link to a traceback?
>
>
>
> On Apr 2, 2017 09:25, "Gary Kotton" <gkotton at vmware.com> wrote:
>
> Hi,
>
> The change https://review.openstack.org/#/c/402750/ has broken the
> vmware-nsx plugin. I am not sure if this has had effect on any other
> decomposed plugins.
>
> One of the issues that we have is when we create a PortDNS object under a
> transaction we get an exception: DBReferenceError: (sqlite3.IntegrityError)
> FOREIGN KEY constraint failed [SQL: u'INSERT INTO portdnses (port_id,
> current_dns_name, current_dns_domain, previous_dns_name,
> previous_dns_domain, dns_name) VALUES (?, ?, ?, ?, ?, ?)'] [parameters:
> ('2f2039ac-e7e6-4cc3-a8a0-3298089d4afb', u'', u'', u'', u'',
> u'port-dns-name')]
>
> Any ideas?
>
> Thanks
>
> Gary
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> --
>
> Regards,
> Ann Taraday
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
> --
> Regards,
> Ann Taraday
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20170404/8efe1494/attachment.html>


More information about the OpenStack-dev mailing list