[openstack-dev] [tripleo] POC patch for using tripleo-repos for repo setup
openstack at nemebean.com
Tue Nov 22 18:06:56 UTC 2016
On 11/21/2016 05:26 PM, Alex Schultz wrote:
> On Mon, Nov 21, 2016 at 2:57 PM, Ben Nemec <openstack at nemebean.com> wrote:
>> I have a POC patch up to demonstrate the use of the tripleo-repos tool
>>  as a replacement for most of tripleo.sh --repo-setup. It has now passed
>> all of the CI jobs so I wanted to solicit some feedback.
>> There are a few changes related to repo naming because the tool names repo
>> files based on the repo name rather than always calling them something
>> generic like delorean.repo. I think it's less confusing to have the
>> delorean-newton repo file named delorean-newton.repo, but I'm open to
>> discussion on that.
>> If no one has any major objections to how the tool looks/works right now,
>> I'll proceed with the work to get it imported into the openstack namespace
>> as part of TripleO. We can always iterate on it after import too, of
>> course, so this isn't a speak now or forever hold your peace situation. :-)
> Why a python standalone application for the management of specifically
> (and only?) tripleo repositories. It seems we should be trying to
> leverage existing tooling and not hiding the problem behind a python
> app. It's not that I enjoy the current method described in the spec
> (3 curls, 1 sed, 1 bash thing, and a yum install) but it seems like to
> write 586 lines of python and tests might be the wrong approach.
> Would it be better to just devote some time to rpm generation for
> these and deliver it in discrete RPMs? 'yum install
> http://tripleo.org/repos-current.rpm' seems way more straight forward.
That's essentially trading "curl ..." for "yum install ..." in the docs.
The repo rpm would have to be part of the delorean build so you'd
still have to be pointing people at a delorean repo. It would also
still require code changes somewhere to handle the mixed
current/current-tripleo setup that we run for development and test.
Given how specific to tripleo that is I'm not sure how much sense it
makes to implement it elsewhere.
There are also optional ceph and opstool repos and at least ceph needs
to match the version of OpenStack being installed. Sure, you could just
document all that logic, but then the logic has to be reimplemented in
CI anyway so you end up with code to maintain either way. At least with
one tool the logic is shared between the user and dev/test paths, which
is one of the primary motivations behind it. Pretty much every place
that we have divergence between what users do and what developers do
becomes a pain point for users because developers only fix the things
they actually use.
There are other benefits too - the tool cleans up old repos so you don't
have to worry about accidentally being left with a stray repo file that
could cause problems. You can also install the repos to a non-system
path so you can make use of them without actually installing them on the
host system. I'm not entirely clear on the use case for that, but it's
something that comes up from time to time.
>> 1: https://review.openstack.org/#/c/395813
>> (note that this spec was mistakenly submitted as a policy, it will be moving
>> to the ocata directory soon)
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev