Open Stack

Hi Liping Mao,

Please find my response inline. If still not clear or i am wrong somewhere
please let me know.

Regards
Vikas

On Fri, May 27, 2016 at 10:37 AM, 毛立平 <maoliping455 at 163.com> wrote:

> Hi Irena,
>
> Thanks for your comments.
>
> Currently, kuryr will create gw port with owner kuryr:container, but this
> GW can't work obviously.
>
In current code, as per my understanding, we are not creating gw port. If
there are no pre-existing subnets and request for gw address is received,
this 'if' condition
<https://github.com/openstack/kuryr/blob/master/kuryr/controllers.py#L1118>
will not met and no gw port will be created.

As the bug is saying, issue is there if there are pre-existing subnets and
this if condition
<https://github.com/openstack/kuryr/blob/master/kuryr/controllers.py#L1118>
met. In this case it is creating a port for gw address which is not
expected.
To fix this we can add logic for checking if it is gw address request
(using "request_type") before this if condition and in case it is then
verify if requested address is same as subnet gateway address. If not same
two choices:
1) Either return to the libnetwork this actual subnet gw in response.
(Antoni suggestion)
   OR
2) Raise an exception as docker users request cannot be met.


> it can be modified to create gw port with owner network:router_interface,
> but seems like CNM module
> do not have action can be map with attach GW with vrouter.
>
> Do we have any reason why we need just create a neutron port but do not
> use it(attach to vrouter)?
>
> So I still think we can leave it in neutron router-interface-add /
> router-interface-delete .
>  what do you think?
>
> Regards,
> Liping Mao
>
>
> At 2016-05-26 20:03:24, "Irena Berezovsky" <irenab.dev at gmail.com> wrote:
>
> Hi Liping Mao,
>
>
> On Thu, May 26, 2016 at 12:31 PM, Liping Mao (limao) <limao at cisco.com>
> wrote:
>
>> Hi Vikas, Antoni and Kuryr team,
>>
>> When I use kuryr, I notice kuryr will failed to add an existed
>> network with gateway interface already created by neutron[1][2].
>>
>> The bug is because kuryr will create a neutron port for gw
>> port in ipam_request_address.
>>
>> I think kuryr should not do actual create neutron gw port at all.
>> Because CNM module do not have concept map with Neutron vRouter.
>> Till now, user have to use neutron api to attach GW port in
>> private network with vRouter. So I think the Kuryr should not
>> actually create GW port.
>>
>> I think it possible to define via kuryr configuration file if kuryr
> should create or not gw port. Kuryr already does it for DHCP port.
>
>> What do you think? Thanks for any comments.
>>
>>
>> [1] https://bugs.launchpad.net/kuryr/+bug/1584286
>> [2] https://review.openstack.org/#/c/319524/4
>>
>>
>>
>> Regards，
>> Liping Mao
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160527/8733fe34/attachment.html>