[openstack-dev] When to revert a patch?

Monty Taylor mordred at inaugust.com
Fri Mar 4 15:16:26 UTC 2016

On 03/04/2016 08:37 AM, Ruby Loo wrote:
> Hijacked from ' [openstack-dev] [ironic] Remember to follow RFE process'
> thread:
>         > Should we revert the patch [1] for now? (Disclaimer. I haven't looked at the
>         > patch itself. But I don't think I should have to, to know what the API
>         > change is.)
>         >
>         Thanks for calling it out Ruby, that's unfortunate that the
>         patch was
>         merged without the RFE being approved. About reverting the patch I
>         think we shouldn't do that now because the patch is touching the API
>         and introducing a new microversion to it.
>     Exactly. I've -2'ed the revert, as removing API version is even
>     worse than landing a change without an RFE approved. Let us make
>     sure to approve RFE asap, and then adjust the code according to it.
> This brings up another issue, which I recall discussing before. Did we
> decide that we'd never revert something that touches the
> API/microversion? It might be good to have guidelines on this if we
> don't already. IF the API is incorrect? If the API could be improved? If
> the API was only in master for eg 48 hours?

I believe you need to treat master as if it's deployed to production. So 
once an API change is released, 'fixing' it needs to be done like any 
other API change - with a microversion bump and appropriate backwards 

(For instance, I have a CI/CD pipeline merging from master every hour 
and doing a deploy - so 48 hours is a long time ago)


More information about the OpenStack-dev mailing list