[openstack-dev] When to revert a patch?
rlooyahoo at gmail.com
Fri Mar 4 14:37:49 UTC 2016
Hijacked from ' [openstack-dev] [ironic] Remember to follow RFE process'
> Should we revert the patch  for now? (Disclaimer. I haven't looked at
>> > patch itself. But I don't think I should have to, to know what the API
>> > change is.)
>> Thanks for calling it out Ruby, that's unfortunate that the patch was
>> merged without the RFE being approved. About reverting the patch I
>> think we shouldn't do that now because the patch is touching the API
>> and introducing a new microversion to it.
> Exactly. I've -2'ed the revert, as removing API version is even worse than
> landing a change without an RFE approved. Let us make sure to approve RFE
> asap, and then adjust the code according to it.
This brings up another issue, which I recall discussing before. Did we
decide that we'd never revert something that touches the API/microversion?
It might be good to have guidelines on this if we don't already. IF the API
is incorrect? If the API could be improved? If the API was only in master
for eg 48 hours?
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev