[openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?
rlrossit at linux.vnet.ibm.com
Thu Jan 28 19:55:48 UTC 2016
> On Jan 28, 2016, at 1:32 PM, Doug Hellmann <doug at doughellmann.com> wrote:
> Excerpts from Hayes, Graham's message of 2016-01-28 19:02:57 +0000:
>> On 28/01/2016 18:44, Davanum Srinivas wrote:
>>> Quite unfair characterization of Oslo being -2 heavy. Please compare
>>> stats before making such an assertion:
>> OK - that was probably my frustration boiling over at the time. I should
>> not have made that generalization. I had been involved in 3 patches to
>> olso repos in the last week, and 2 got -2'd, and that came out unfairly
>> in this message.
> As Dims pointed out, the ratio of -2s on your recent patches is an
> aberration. It just happens that you've picked some tricky things
> to work on, and those things need more communication than they might
> in other projects because of the nature of Oslo. Please don't
> interpret them as shutting down discussion.
>> The initial -2s where not as annoying as the stickyness of them. When
>> the issues that led to the -2's were fixed, they were not moved to -1.
>> I see -2's as vetos - if I am mistaken please tell me, but that is how
>> most of the openstack projectsm and other projects using gerrit seem
>> to have treated them.
> Veto has a lot of connotations. In my case, the -2 is an indication
> that I think the requested change is a bad idea that needs more
> justification. I hadn't seen some of the recent comments on that
> patch because I've been working on something else today. I've
> suggested moving the conversation to the mailing list. After that
> discussion, we'll know the path forward.
Oslo is a special case where I think -2’s are more necessary than other projects. Because libraries are used by many projects, you don’t want to suddenly change something over that will break a project. Sometimes, yeah it happens, but if you know you’re going to break someone, don’t do it.
I like the stickiness of -2’s. As a person that isn’t core in anything, I get really frustrated in some situations where I put down a -1, someone updated the patch, and then it got merged before I could come back to it, but I still find something wrong. Now the onus is on me to get that fixed up. Granted my situations have been much less drastic (i.e. not a breaking change). Oslo is comprised of a lot of diverse knowledge. If someone knows of a breakage from a change, you don’t want that to get covered up by a new patch that “fixes” it. A -2 is (or should) never be a “I hate this patch”, it should be a “we need to discuss this further”.
> I believe Dan is at the Nova mid-cycle this week, so it's likely
> his -2 will be pretty sticky for now, too, since I expect he's
> otherwise occupied as well.
As a guy who tries to get Dan’s attention a lot, yeah he’s a busy guy. But as a benefit of annoying him so much, I think (or at least hope) I’ve learned quite a bit under him. One of the benefits of me not being core on anything is that I’m usually more available for questions :). I might have to play the “I don’t know” card pretty frequently, but it doesn’t hurt to ask :)
>>> On the one single specific review you had a -2, you should be talking
>>> to the reviewer on IRC or bring it to the next Oslo meeting.
>> Did that. And on the review itself.
>>> On Thu, Jan 28, 2016 at 12:29 PM, Joshua Harlow <harlowja at fastmail.com> wrote:
>>>> Hayes, Graham wrote:
>>>>> Also, olso seem to be very-2 heavy. This means that alternative views
>>>>> on the review are very unlikely. My question is what is the difference
>>>>> between a-1 and a-2 for oslo?
>>>> If this is the case I am sorry about it, and I'd also like to think that we
>>>> (as the oslo team) need not do this (or think about it more before we do
>>>> it), because it usually isn't really needed (a -1 suffices IMHO for most
>>>> things, especially things that are being actively discussed).
>>>> But I'm also in the camp that thinks the whole -1 or -2 is sorta dumb and
>>>> IMHO just leaving comments and talking to people on IRC to work through
>>>> issues/discussion/code is better...
>>>> But then that requires people<->people interaction and I guess not everyone
>>>> likes to do that(?)
>>>> In general I hope it's not all of oslo u are grouping here because, if its
>>>> just a few cases, hopefully we can work with the person that is -2ing stuff
>>>> to not do it willy nilly...
>>>> My 2 cents,
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
Ryan Rossiter (rlrossit)
More information about the OpenStack-dev