[openstack-dev] [oslo][oslo.versionedobjects] Is it possible to make changes to oslo repos?
graham.hayes at hpe.com
Thu Jan 28 19:02:57 UTC 2016
On 28/01/2016 18:44, Davanum Srinivas wrote:
> Quite unfair characterization of Oslo being -2 heavy. Please compare
> stats before making such an assertion:
OK - that was probably my frustration boiling over at the time. I should
not have made that generalization. I had been involved in 3 patches to
olso repos in the last week, and 2 got -2'd, and that came out unfairly
in this message.
The initial -2s where not as annoying as the stickyness of them. When
the issues that led to the -2's were fixed, they were not moved to -1.
I see -2's as vetos - if I am mistaken please tell me, but that is how
most of the openstack projectsm and other projects using gerrit seem
to have treated them.
> On the one single specific review you had a -2, you should be talking
> to the reviewer on IRC or bring it to the next Oslo meeting.
Did that. And on the review itself.
> On Thu, Jan 28, 2016 at 12:29 PM, Joshua Harlow <harlowja at fastmail.com> wrote:
>> Hayes, Graham wrote:
>>> Also, olso seem to be very-2 heavy. This means that alternative views
>>> on the review are very unlikely. My question is what is the difference
>>> between a-1 and a-2 for oslo?
>> If this is the case I am sorry about it, and I'd also like to think that we
>> (as the oslo team) need not do this (or think about it more before we do
>> it), because it usually isn't really needed (a -1 suffices IMHO for most
>> things, especially things that are being actively discussed).
>> But I'm also in the camp that thinks the whole -1 or -2 is sorta dumb and
>> IMHO just leaving comments and talking to people on IRC to work through
>> issues/discussion/code is better...
>> But then that requires people<->people interaction and I guess not everyone
>> likes to do that(?)
>> In general I hope it's not all of oslo u are grouping here because, if its
>> just a few cases, hopefully we can work with the person that is -2ing stuff
>> to not do it willy nilly...
>> My 2 cents,
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev