Open Stack

On Jan 22, 2016, at 19:14, Matthew Treinish <mtreinish at kortar.org> wrote:

> Although, now that I look at the list it definitely looks like this one,
> which I had forgotten about:
> 
> https://bugs.launchpad.net/os-testr/+bug/1506215
> 
> It sounds like that bug proposes a direction so if you could patch os-testr
> to give that a try and see if that fixes your issue. If it does then we can
> just land that in os-testr.

Thanks!! That's indeed the same problem and removing the '$' from the exclude_regex worked for me. (ostestr --blacklist_file tests-py3.txt --regex "nova.tests.unit.network" ran all non-blacklisted network tests)

> However, I'm wondering if it makes more sense to change how the selection
> actually works with os-testr. This regex generation approach does get pretty
> unwieldy and seems very error prone. I'm thinking it might make more sense to
> generate a test-list and then have os-testr filter that list itself and then
> pass the pruned list to --load-list in testr run.

I could see that because conceptually the test selection has two stages: produce a list of non-blacklisted tests, then filter that list further as desired. Personally, using --blacklist_file and --regex seemed straightforward to me since I could specify the filter regex as I'm used to doing. It worked in my case but there might be cases I can't think of where the append method won't be able to give the desired result.


-melanie






-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160125/93ce1e03/attachment.pgp>