[openstack-dev] [nova] gate blockage due to eventlet 0.18

Sean Dague sean at dague.net
Mon Jan 25 11:37:24 UTC 2016


On 01/25/2016 03:36 AM, Victor Stinner wrote:
> Hi,
> 
> Oops, I feel guilty, I wrote the patch which introduced the regression
> :-/ My patch fixes a bug on Python 3: "sock.makefile('rb').readline()
> doesn't handle blocking errors correctly"
> https://github.com/eventlet/eventlet/issues/274
> 
> I was relying on the eventlet test suite, but it looks like it lacks an
> unit test on sendto(). FYI I sent a pull request sunday, but just after
> that I noticed that Jakub Stasiak already fixed the regression. My new
> pull request adds an unit test on sendto() and recvfrom() (UDP socket)
> which should help to avoid similar regression:
> https://github.com/eventlet/eventlet/pull/292
> 
> The best would be to run some OpenStack tests on the development branch
> of eventlet in a CI, or at least run OpenStack tests on new eventlet
> release. It became common to see regression on eventlet releases, it
> looks like eventlet test suite is too small.

Thanks everyone for getting to the bottom of this. 0.18.1 seems to have
fixed everything, and we're back in business now.

	-Sean

-- 
Sean Dague
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20160125/d4fa6c81/attachment.pgp>


More information about the OpenStack-dev mailing list