[openstack-dev] [legal-discuss] [all][tc][kolla]is it OK to modify python code in OpenStack project?
Jeffrey Zhang
zhang.lei.fly at gmail.com
Tue Dec 27 06:40:33 UTC 2016
not simple override the _read() method. I also copied some code from
ConfigParser.py(more than 80%, i think). is that OK?
is there any difference between override method and copy codes?
On Tue, Dec 27, 2016 at 3:12 AM, Monty Taylor <mordred at inaugust.com> wrote:
> On 12/26/2016 07:27 AM, Davanum Srinivas wrote:
> > PSF is ok per (https://governance.openstack.org/tc/reference/licensing.
> html)
> > Though the overriding the _read() seems like something that could
> > break easily
>
> Yah - you can't relicense it - but you can include it with the PSF
> license. It might be worth adding a PSF license header to that file and
> a note that the code is copied from [0]
>
> That said - I agree with dims, overriding the _read() method like that
> seems prone to sadness.
>
> > On Mon, Dec 26, 2016 at 12:13 PM, Michał Jastrzębski <inc007 at gmail.com>
> wrote:
> >> Added all and tc tags, as it might affect everyone really.
> >>
> >> On 25 December 2016 at 23:04, Jeffrey Zhang <zhang.lei.fly at gmail.com>
> wrote:
> >>> Recently, Kolla project has requirement to modify[1] the python's
> >>> ConfigParser.py code[0].
> >>>
> >>> Python is using PSF license[3], which is GPL compatible. But OpenStack
> >>> is using Apache License.
> >>>
> >>> Here is the diff view[2].
> >>>
> >>> I want to make sure: is it OK to re-license ConfigParser.py? If not,
> what
> >>> the solution?
> >>>
> >>> [0] https://github.com/python/cpython/blob/2.7/Lib/ConfigParser.py
> >>> [1] https://review.openstack.org/412101
> >>> [2]
> >>> https://gist.github.com/jeffrey4l/2258b276cbd038e73797cfa0952da3
> 71/revisions?diff=split
> >>> [3] https://docs.python.org/3/license.html
> >>>
> >>>
> >>> --
> >>> Regards,
> >>> Jeffrey Zhang
> >>> Blog: http://xcodest.me
> >>>
> >>> _______________________________________________
> >>> legal-discuss mailing list
> >>> legal-discuss at lists.openstack.org
> >>> http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss
> >>>
> >>
> >> _______________________________________________
> >> legal-discuss mailing list
> >> legal-discuss at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss
> >
> >
> >
>
>
> _______________________________________________
> legal-discuss mailing list
> legal-discuss at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss
>
--
Regards,
Jeffrey Zhang
Blog: http://xcodest.me
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20161227/4280cde7/attachment.html>
More information about the OpenStack-dev
mailing list