<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">not simple override the _read() method. I also copied some code from ConfigParser.py(more than 80%, i think). is that OK?</div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small"><br></div><div class="gmail_default" style="font-family:monospace,monospace;font-size:small">is there any difference between override method and copy codes?</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Dec 27, 2016 at 3:12 AM, Monty Taylor <span dir="ltr"><<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 12/26/2016 07:27 AM, Davanum Srinivas wrote:<br>
> PSF is ok per (<a href="https://governance.openstack.org/tc/reference/licensing.html" rel="noreferrer" target="_blank">https://governance.openstack.<wbr>org/tc/reference/licensing.<wbr>html</a>)<br>
> Though the overriding the _read() seems like something that could<br>
> break easily<br>
<br>
</span>Yah - you can't relicense it - but you can include it with the PSF<br>
license. It might be worth adding a PSF license header to that file and<br>
a note that the code is copied from [0]<br>
<br>
That said - I agree with dims, overriding the _read() method like that<br>
seems prone to sadness.<br>
<div class="HOEnZb"><div class="h5"><br>
> On Mon, Dec 26, 2016 at 12:13 PM, Michał Jastrzębski <<a href="mailto:inc007@gmail.com">inc007@gmail.com</a>> wrote:<br>
>> Added all and tc tags, as it might affect everyone really.<br>
>><br>
>> On 25 December 2016 at 23:04, Jeffrey Zhang <<a href="mailto:zhang.lei.fly@gmail.com">zhang.lei.fly@gmail.com</a>> wrote:<br>
>>> Recently, Kolla project has requirement to modify[1] the python's<br>
>>> ConfigParser.py code[0].<br>
>>><br>
>>> Python is using PSF license[3], which is GPL compatible. But OpenStack<br>
>>> is using Apache License.<br>
>>><br>
>>> Here is the diff view[2].<br>
>>><br>
>>> I want to make sure: is it OK to re-license ConfigParser.py? If not, what<br>
>>> the solution?<br>
>>><br>
>>> [0] <a href="https://github.com/python/cpython/blob/2.7/Lib/ConfigParser.py" rel="noreferrer" target="_blank">https://github.com/python/<wbr>cpython/blob/2.7/Lib/<wbr>ConfigParser.py</a><br>
>>> [1] <a href="https://review.openstack.org/412101" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>412101</a><br>
>>> [2]<br>
>>> <a href="https://gist.github.com/jeffrey4l/2258b276cbd038e73797cfa0952da371/revisions?diff=split" rel="noreferrer" target="_blank">https://gist.github.com/<wbr>jeffrey4l/<wbr>2258b276cbd038e73797cfa0952da3<wbr>71/revisions?diff=split</a><br>
>>> [3] <a href="https://docs.python.org/3/license.html" rel="noreferrer" target="_blank">https://docs.python.org/3/<wbr>license.html</a><br>
>>><br>
>>><br>
>>> --<br>
>>> Regards,<br>
>>> Jeffrey Zhang<br>
>>> Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a><br>
>>><br>
>>> ______________________________<wbr>_________________<br>
>>> legal-discuss mailing list<br>
>>> <a href="mailto:legal-discuss@lists.openstack.org">legal-discuss@lists.openstack.<wbr>org</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>legal-discuss</a><br>
>>><br>
>><br>
>> ______________________________<wbr>_________________<br>
>> legal-discuss mailing list<br>
>> <a href="mailto:legal-discuss@lists.openstack.org">legal-discuss@lists.openstack.<wbr>org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>legal-discuss</a><br>
><br>
><br>
><br>
<br>
<br>
______________________________<wbr>_________________<br>
legal-discuss mailing list<br>
<a href="mailto:legal-discuss@lists.openstack.org">legal-discuss@lists.openstack.<wbr>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/legal-discuss" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>legal-discuss</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</div></div>