[openstack-dev] [Nova] Does this api modification need Microversion?
Jay Pipes
jaypipes at gmail.com
Wed Aug 3 15:06:38 UTC 2016
On 08/03/2016 10:03 AM, Matt Riedemann wrote:
> On 8/2/2016 1:11 AM, han.rong3 at zte.com.cn wrote:
>> patchset url: https://review.openstack.org/#/c/334747/
>>
>> Allow "revert_resize" to recover error instance after resize/migrate.
>>
>> When resize/migrate instance, if error occurs on source compute node,
>> instance state can rollback to active currently. But if error occurs in
>> "finish_resize" function on destination compute node, the instance state
>> would not rollback to active.
>>
>> This patch is to rollback instance state from error to active when
>> resize or migrate action failed on destination compute node..
>>
>> Best,
>>
>> Rong Han
>
> I lean toward yes for this needing a microversion as it's a behavior
> change and without a microversion, how am I as an end user of the API
> supposed to have any idea that I can perform this action and have a
> chance of it working? We've said the same thing for other stuff like
> this, like being able to rescue a volume-backed instance:
>
> https://review.openstack.org/#/c/270288/18/nova/compute/api.py
This is a grey area for sure. Personally, I kind of view this as a bug
fix, not really a behaviour change that needs to be communicated to the
API end user. But I suppose I could see the case for needing a
microversion, so I'll just go along with whatever the API WG thinks.
Best,
-jay
More information about the OpenStack-dev
mailing list