[openstack-dev] [OpenStack-Infra] Announcing Gertty 1.4.0

Roman Dobosz roman.dobosz at intel.com
Tue Aug 2 05:54:55 UTC 2016


On Mon, 1 Aug 2016 17:38:59 -0500
Mikhail Medvedev <mihailmed at gmail.com> wrote:

> > We essentially have two channels of information that we want to
> > represent with color -- the diff, and the syntax.  They can sometimes
> > overlap.
> >
> > Perhaps we could use a 256 color (or even RGB) terminal for this
> > feature.  Then we may be able to get just the right shade of background
> > color for the diff channel, and use the foreground colors for syntax
> > highlighting.
> >
> > At any rate, it may be worth trying to solve *this* problem first with a
> > mockup to see if there is any way of doing this without making our eyes
> > bleed before working on the code to implement it.
> 
> In theory it is possible split diff and syntax spatially, so there
> would be no need to mix diff and syntax colors. Mockup
> http://i.imgur.com/gAD9x9v.png

What is missing in this picture are changes, which are small enough to
take out entire line, like typos, spaces, punctuation and so on.

IMHO using 256 color terminal emulator is not fancy thing in 2016.
Maybe James suggestion wasn't so pointless? In 256 color capable
terminal, vim diff might can look more or less pleasant depending on
colorscheme:

http://www.math.bas.bg/bantchev/vim/gvimdiff-clue.png
http://pic002.cnblogs.com/images/2012/272919/2012020912181654.jpg
http://thenewstack.io/wp-content/uploads/2016/03/vimdiff.png

Another idea would be to use vim itself as the interface, and provide a
vim plugin (which could be written in python) for review activities.
Although it may be unsuitable for other editor users.

-- 
Cheers,
Roman Dobosz



More information about the OpenStack-dev mailing list