[openstack-dev] [murano] Fix order of arguments in assertEqual

Tetiana Lashchova tlashchova at mirantis.com
Thu Sep 24 07:45:32 UTC 2015


Hi folks!

Some tests in murano code use incorrect order of arguments in assertEqual.
The correct order expected by the testtools is

        def assertEqual(self, expected, observed, message=''):
            """Assert that 'expected' is equal to 'observed'.

            :param expected: The expected value.
            :param observed: The observed value.
            :param message: An optional message to include in the error.
            """

Error message has the following format:

raise mismatch_error
    testtools.matchers._impl.MismatchError: !=:
    reference = <expected value>
    actual    = <observed value>

Use of arguments in incorrect order could make debug output very confusing.
Let's fix it to make debugging easier.

Best regards,
Tetiana Lashchova
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150924/c627798b/attachment.html>


More information about the OpenStack-dev mailing list