Open Stack

On Thu, Sep 17, 2015 at 11:31 AM, Eric Harney <eharney at redhat.com> wrote:

> On 09/17/2015 05:00 AM, Duncan Thomas wrote:
> > On 16 September 2015 at 23:43, Eric Harney <eharney at redhat.com> wrote:
> >
> >> Currently, at least some options set in [DEFAULT] don't apply to
> >> per-driver sections, and require you to set them in the driver section
> >> as well.
> >>
> >
> > This is extremely confusing behaviour. Do you have any examples? I'm not
> > sure if we can fix it without breaking people's existing configs but I
> > think it is worth trying. I'll add it to the list of things to talk about
> > briefly in Tokyo.
> >
>
> The most recent place this bit me was with iscsi_helper.
>
> If cinder.conf has:
>
> [DEFAULT]
> iscsi_helper = lioadm
> enabled_backends = lvm1
>
> [lvm1]
> volume_driver = ...LVMISCSIDriver
> # no iscsi_helper setting
>
>
> You end up with c-vol showing "iscsi_helper = lioadm", and
> "lvm1.iscsi_helper = tgtadm", which is the default in the code, and not
> the default in the configuration file.
>
> I agree that this is confusing, I think it's also blatantly wrong.  I'm
> not sure how to fix it, but I think it's some combination of your
> suggestions above and possibly having to introduce new option names.
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
​
I'm not sure why that's "blatantly wrong', this is a side effect of having
multiple backends enabled, it's by design really.  Any option that is
defined in driver.py needs to be set in the actual enabled-backend stanza
IIRC.  This includes iscsi_helper, volume_clear etc.

Having the "global conf" settings intermixed with the backend sections
caused a number of issues when we first started working on this.  That's
part of why we require the "self.configuration" usage all over in the
drivers.  Each driver instantiation is it's own independent entity.

I haven't looked at this for a long time, but if something has changed or
I'm missing something my apologies.  We can certainly consider changing it,
but because of the way we do multi-backend I'm not exactly sure how you
would do this, or honestly why you would want to.

John
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150917/cbc409ba/attachment.html>