[openstack-dev] [neutron] pushing changes through the gate

Armando M. armamig at gmail.com
Fri Sep 4 02:36:51 UTC 2015


On 3 September 2015 at 17:55, Hirofumi Ichihara <
ichihara.hirofumi at lab.ntt.co.jp> wrote:

> Good work and thank you for your help with my patch.
>
> Anyway, I don’t know when does bp owner have to merge the code by.
> I can see the following sentence in bp rule[1]
> “The PTL will create a <release>-backlog directory during the RC window
> and move all specs which didn’t make the <release> there.”
> Did we have to merge the implementation by L-3? Or can we merge it in RC-1?
>
> [1]:
> http://docs.openstack.org/developer/neutron/policies/blueprints.html#neutron-bp-and-spec-notes
>
>
It depends on the extent of the changes remaining to merge. There is no
hard and fast rule, because every blueprint is different: the code can be
complex and pervasive, or simple and isolated. In the former even a small
patch may be deferred, in the latter even a dozen patches could be merged
during RC. Some other blueprints are best completed during feature freeze,
because of the rebase risk they cause...

Bottom line: never leave it to last minute!


> Thanks,
> Hirofumi
>
> On 2015/09/04, at 7:00, Armando M. <armamig at gmail.com> wrote:
>
>
>
> On 2 September 2015 at 09:40, Armando M. <armamig at gmail.com> wrote:
>
>> Hi,
>>
>> By now you may have seen that I have taken out your change from the gate
>> and given it a -2: don't despair! I am only doing it to give priority to
>> the stuff that needs to merge in order to get [1] into a much better shape.
>>
>> If you have an important fix, please target it for RC1 or talk to me or
>> Doug (or Kyle when he's back from his time off), before putting it in the
>> gate queue. If everyone is not conscious of the other, we'll only end up
>> stepping on each other, and nothing moves forward.
>>
>> Let's give priority to gate stabilization fixes, and targeted stuff.
>>
>> Happy merging...not!
>>
>> Many thanks,
>> Armando
>>
>> [1] https://launchpad.net/neutron/+milestone/liberty-3
>> [2] https://launchpad.net/neutron/+milestone/liberty-rc1
>>
>
> Download files for the milestone are available in [1]. We still have a lot
> to do as there are outstanding bugs and blueprints that will have to be
> merged in the RC time windows.
>
> Please be conscious of what you approve. Give priority to:
>
> - Targeted bugs and blueprints in [2];
> - Gate stability fixes or patches that aim at helping troubleshooting;
>
> In these busy times, please refrain from proposing/merging:
>
> - Silly rebase generators (e.g. spelling mistakes);
> - Cosmetic changes (e.g. minor doc strings/comment improvements);
> - Refactoring required while dealing with the above;
> - A dozen of patches stacked on top of each other;
>
> Every rule has its own exception, so don't take this literally.
>
> If you are unsure, please reach out to me, Kyle or your Lieutenant and
> we'll target stuff that is worth targeting.
>
> As for the rest, I am gonna be merciless and -2 anything than I can find,
> in order to keep our gate lean and sane :)
>
> Thanks and happy hacking.
>
> A.
>
> [1] https://launchpad.net/neutron/+milestone/liberty-3
> [2] https://launchpad.net/neutron/+milestone/liberty-rc1
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150903/05913eda/attachment.html>


More information about the OpenStack-dev mailing list