[openstack-dev] [Nova] Using depends-on for patches which require an approved spec
Devananda van der Veen
devananda.vdv at gmail.com
Wed May 27 18:15:01 UTC 2015
I think this will help because it separates the judgement of "is this code
good enough to land" from the project and release coordination of "should
this code land now".
I've been floating the idea of separating +2 and +A powers for the same
purpose: free up many of the technical reviewers from having to *also*
think about release schedules and project priorities, since larger projects
are tending towards having a smaller group of "project-drivers" who handle
the latter question.
It looks like Depends-On is one way to address that, and it's fairly light
weight; since we can edit the review message, core-reviewers can add that
line if they feel it's needed, without needing to -1 the code in question.
I'm open to trying it in the Ironic project.
-Devananda
On Tue, May 26, 2015 at 8:45 AM Daniel P. Berrange <berrange at redhat.com>
wrote:
> On Fri, May 22, 2015 at 02:57:23PM -0700, Michael Still wrote:
> > Hey,
> >
> > it would be cool if devs posting changes for nova which depend on us
> > approving their spec could use Depends-On to make sure their code
> > doesn't land until the spec does.
>
> Does it actually bring any benefit ? Any change for which there is
> a spec is already supposed to be tagged with 'Blueprint: foo-bar-wiz'
> and nova core devs are supposed to check the blueprint is approved
> before +A'ing it. So also adding a Depends-on just feels redundant
> to me, and so is one more hurdle for contributors to remember to
> add. If we're concerned people forget the Blueprint tag, or forget
> to check blueprint approval, then we'll just have same problem with
> depends-on - people will forget to add it, and cores will forget
> to check the dependant change. So this just feels like extra rules
> for no gain and extra pain.
>
> Regards,
> Daniel
> --
> |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/
> :|
> |: http://libvirt.org -o- http://virt-manager.org
> :|
> |: http://autobuild.org -o- http://search.cpan.org/~danberr/
> :|
> |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc
> :|
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150527/8c85a5b1/attachment.html>
More information about the OpenStack-dev
mailing list