[openstack-dev] Beyond IRC (was Re: Cinder Third-Party CI: what next?)
anteaya at anteaya.info
Wed Mar 25 16:32:28 UTC 2015
On 03/25/2015 12:14 PM, Kevin L. Mitchell wrote:
> On Tue, 2015-03-24 at 21:21 -0400, Doug Hellmann wrote:
>>>> · A separate mailing list for project review requests
>>> I'm skeptical about this being effective: just another source of
>>> incoming email that needs to be filtered out (at which point a mailman
>>> topic would have the same effect).
>> Yes, email notifications scale poorly for really active reviewers.
>> Between gerrit and launchpad, there is already a lot of notification
>> email being filtered out of inboxes.
> I actually do rely on email notifications for review duties. I use
> filtering that moves the messages into dedicated folders per repository,
> and I use threading in those folders. When I see a review merge (or
> when I see it abandoned), I select the whole thread and delete it;
> otherwise I follow changes made to a review and determine whether I need
> to re-review it based on whether votes to that point have been +'s or
> -'s. I even subscribe to a couple of projects and check out new reviews
> submitted there. This is actually partly to blame for me being such a
> prolific reviewer in nova and novaclient :)
One thing I have learned from my experiences at many mid-cycles is there
is no one size fits all review workflow. I'm glad email works for you.
Others don't read a single email gerrit emits. So advising someone that
their review would get more attention by using email is not necessarily
true. I would get attention from a portion of reviewers and would be
totally ignored by others.
Projects are all different in their workflows and this includes their
review workflows. To understand how any given project prioritizes
reviews one must attend the project weekly meeting, participate in
discussions, ask questions, listen and follow advice given. All projects
genuinely want to help developers succeed. Folks pay more attention to
those wanting to participate when they take the trouble to find out what
More information about the OpenStack-dev