[openstack-dev] [glance] reminder to check 'Author' of patch set when reviewing

Jeremy Stanley fungi at yuggoth.org
Mon Mar 23 16:19:01 UTC 2015


On 2015-03-23 15:52:35 +0000 (+0000), stuart.mclaren at hp.com wrote:
> A quick reminder for Glance cores to check if the 'Author' changes
> between patch sets.
[...]

Also a quick reminder to all devs. If you stick to git commands for
manipulating commits then it should be _very_hard_ to accidentally
reset the author (you have to pass a specific option to
intentionally do that).

Most of the time when I see this happen it's because someone
unfamiliar with git's toolset hand-patches modifications into an
entirely new commit, which is a terrible waste of time that could
instead be spent learning how to use git.
-- 
Jeremy Stanley



More information about the OpenStack-dev mailing list