[openstack-dev] Deprecation warnings considered harmful?

Doug Hellmann doug at doughellmann.com
Fri Mar 13 15:36:54 UTC 2015



On Fri, Mar 13, 2015, at 07:25 AM, Ihar Hrachyshka wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 03/13/2015 01:37 AM, Nikhil Manchanda wrote:
> > Looking back at the meeting eavesdrop, the primary reasons why we 
> > deferred this work to Liberty was twofold:
> > 
> > - It wasn't a set plan based on information available to us at the
> > time. This being the case, we decided to wait until we had more
> > information regarding the requirements around this from oslo.
> > 
> > - We wanted to ensure that we had a corresponding hacking rule in 
> > place to prevent future patch-sets from using the deprecated
> > module names.
> > 
> 
> For hacking check, I have a patch in review for 'hacking' repo to add
> checks (both for stable branches where oslo.* namespace is used, and
> new branches where oslo_* is expected):
> 
> - - https://review.openstack.org/157894
> 
> Also, neutron has a (test covered) hacking check at:
> 
> http://git.openstack.org/cgit/openstack/neutron/tree/neutron/hacking/checks.py#n119
> 
> Feel free to adopt.

I wish we, as a community, were less obsessed with creating so many
hacking rules. These are really minor changes and it's going to be a
relatively short-lived issue that could just be fixed once. If there's a
regression, fixing *that* won't be hard or take long.

As I said in the IRC snippet pasted into the meeting log linked
elsewhere in the thread, I want to drop the "oslo" package during the
next cycle. It's not clear that all projects will be ready for us to do
that, and that's why it's not a "definite" plan, yet. We're trying to be
cognizant of the fact that you all have other things you're trying to
accomplish too, and that this work appears like code churn even though
it is solving a problem many developers have had in their development
environments. 

In any case, you should plan for all Oslo libraries to drop the
namespace packages entirely *soon*. If not for Liberty then definitely
for M. There's no sense at all in delaying the work needed in your
projects beyond L-1, and landing the changes sooner is better than
waiting.

Doug

> 
> > We specifically didn't consider the impact of logging statements
> > with deprecation warnings at the meeting.
> > 
> > We now have a better picture of the actual status -- with the oslo 
> > decision that these namespace packages are definitely going away. 
> > I've added an agenda item to bring this up again at the next Trove 
> > weekly meeting [1] so that we can address this.
> > 
> > [1] https://wiki.openstack.org/wiki/Meetings/TroveMeeting
> > 
> > Thanks, Nikhil
> > 
> > 
> > 
> > On Thu, Mar 12, 2015 at 4:05 PM, Robert Collins 
> > <robertc at robertcollins.net <mailto:robertc at robertcollins.net>>
> > wrote:
> > 
> > On 13 March 2015 at 09:43, Ihar Hrachyshka <ihrachys at redhat.com 
> > <mailto:ihrachys at redhat.com>> wrote:
> >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> >> 
> >> On 03/12/2015 09:35 PM, Robert Collins wrote:
> >>> On 13 March 2015 at 08:09, Ihar Hrachyshka
> >>> <ihrachys at redhat.com
> > <mailto:ihrachys at redhat.com>>
> >>> wrote:
> >>>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
> >>>> 
> >>>> On 03/12/2015 11:38 AM, Boris Bobrov wrote:
> >>>>> On Thursday 12 March 2015 12:59:10 Duncan Thomas wrote:
> >>>>>> So, assuming that all of the oslo depreciations aren't
> >>>>>> going to be fixed before release
> >>>>> 
> >>>>> What makes you think that?
> >>>>> 
> >>>>> In my opinion it's just one component's problem. These 
> >>>>> particular deprecation warnings are a result of still
> >>>>> on-going migration from oslo.<package> to oslo_<package>.
> >>>>> Ironically, all components except oslo have already moved
> >>>>> to the new naming scheme.
> >>>> 
> >>>> It's actually wrong. For example, Trove decided to stay on
> >>>> using the old namespace for Kilo.
> >>> 
> >>> Why?
> >>> 
> >>> -Rob
> >>> 
> >> 
> >> 
> > http://eavesdrop.openstack.org/irclogs/%23openstack-meeting-alt/%23openstack-meeting-alt.2015-02-11.log
> >
> > 
> > 
> >> starting from "2015-02-11T18:03:11". I guess the assumption was
> >> that there is immediate benefit, and they can just wait. Though I
> >> don't think the fact that it means deprecation warnings in their
> >> logs was appreciated at the time of decision.
> > 
> > Thanks, reading that it looks like the actual status (oslo decided 
> > most definitely that namespace packages are going away, its just a 
> > matter of when) wasn't understood in that meeting.
> > 
> > Is it possible to put it back on the agenda for the next Trove
> > meeting?
> > 
> > Cheers, Rob
> > 
> > -- Robert Collins <rbtcollins at hp.com <mailto:rbtcollins at hp.com>> 
> > Distinguished Technologist HP Converged Cloud
> > 
> > __________________________________________________________________________
> >
> > 
> OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: 
> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe 
> > <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
> >
> > 
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> > 
> > 
> > 
> > __________________________________________________________________________
> >
> > 
> OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> > OpenStack-dev-request at lists.openstack.org?subject:unsubscribe 
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
> 
> iQEcBAEBAgAGBQJVAskYAAoJEC5aWaUY1u57xD0H/13+RPI3IKDu//5FSKoENIwb
> 26cVv00Kd3KIAXWPVSFCzTgNjuRzhHtG0PHc4T18unbtS47zSOZGVE8J0dLlXhQV
> AV9Q3p/qXbjPvGMuUCYDIDI8XGErMXkbZbKRsoEQKKrp2aXupiDJ7u0UoxKNlKOs
> cwIVPYDX7cmRebdb25nYhs3X0L/oHyem6sHtWQCcElLpmIeYoTD/VdAoCy7hQhZc
> s9t5f6xJev0N7/134qh1OhVDTP0UKhgR7N2r8TLUwNN9B1k6RcHxU0Fem6cbE5kZ
> WytbX78LOWY6PDaJ00vfdtgQo+FVvLOfzP2O6BArF8MSQT9kp2QH/GD2EyZ6i7M=
> =RXO/
> -----END PGP SIGNATURE-----
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list