[openstack-dev] [Glance] Nitpicking in code reviews
nikhil.komawar at RACKSPACE.COM
Thu Mar 12 03:56:16 UTC 2015
+1 to what John said (overall).
However, I think I know where Erno is coming from. We're very close to the FF and people are trying hard to get green on the check as well as ensure thoroughness of the feature; this might lead to bunch of these errors.
Pointing them out and expecting to complete the remnant in a follow up patch sounds like a better solution to me rather than holding something important back that may miss the FF.
From: John Bresnahan <john at bresnahan.me>
Sent: Wednesday, March 11, 2015 9:06 PM
To: openstack-dev at lists.openstack.org
Subject: Re: [openstack-dev] [Glance] Nitpicking in code reviews
FWIW I agree with #3 and #4 but not #1 and #2. Spelling is an easy
enough thing to get right and speaks to the quality standard to which
the product is held even in commit messages and comments (consider the
'broken window theory'). Of course everyone makes mistakes (I am a
terrible speller) but correcting a spelling error should be a trivial
matter. If a reviewer notices a spelling error I would expect them to
On 3/11/15 2:22 PM, Kuvaja, Erno wrote:
> Hi all,
> Following the code reviews lately I’ve noticed that we (the fan club
> seems to be growing on weekly basis) have been growing culture of
> nitpicking  and bikeshedding  over almost every single change.
> Seriously my dear friends, following things are not worth of “-1” vote
> if even a comment:
> 1)Minor spelling errors on commit messages (as long as the message comes
> through and flags are not misspelled).
> 2)Minor spelling errors on comments (docstrings and documentation is
> there and there, but comments, come-on).
> 3)Used syntax that is functional, readable and does not break
> consistency but does not please your poem bowel.
> 4)Other things you “just did not realize to check if they were there”.
> After you have gone through the whole change go and look your comments
> again and think twice if your concern/question/whatsoever was addressed
> somewhere else than where your first intuition would have dropped it.
> We have relatively high volume for glance at the moment and this
> nitpicking and bikeshedding does not help anyone. At best it just
> tightens nerves and breaks our group. Obviously if there is “you had ONE
> job” kind of situations or there is relatively high amount of errors
> combined with something serious it’s reasonable to ask fix the typos on
> the way as well. The reason being need to increase your statistics,
> personal perfectionist nature or actually I do not care what; just stop
> or go and do it somewhere else.
> Love and pink ponies,
>  www.urbandictionary.com/define.php?term=nitpicking
>  http://bikeshed.com
>  http://en.wiktionary.org/wiki/bikeshedding
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev