[openstack-dev] [Glance] Nitpicking in code reviews

John Bresnahan john at bresnahan.me
Thu Mar 12 01:06:21 UTC 2015

FWIW I agree with #3 and #4 but not #1 and #2.  Spelling is an easy 
enough thing to get right and speaks to the quality standard to which 
the product is held even in commit messages and comments (consider the 
'broken window theory').  Of course everyone makes mistakes (I am a 
terrible speller) but correcting a spelling error should be a trivial 
matter.  If a reviewer notices a spelling error I would expect them to 
point it.

On 3/11/15 2:22 PM, Kuvaja, Erno wrote:
> Hi all,
> Following the code reviews lately I’ve noticed that we (the fan club
> seems to be growing on weekly basis) have been growing culture of
> nitpicking [1] and bikeshedding [2][3] over almost every single change.
> Seriously my dear friends, following things are not worth of “-1” vote
> if even a comment:
> 1)Minor spelling errors on commit messages (as long as the message comes
> through and flags are not misspelled).
> 2)Minor spelling errors on comments (docstrings and documentation is
> there and there, but comments, come-on).
> 3)Used syntax that is functional, readable and does not break
> consistency but does not please your poem bowel.
> 4)Other things you “just did not realize to check if they were there”.
> After you have gone through the whole change go and look your comments
> again and think twice if your concern/question/whatsoever was addressed
> somewhere else than where your first intuition would have dropped it.
> We have relatively high volume for glance at the moment and this
> nitpicking and bikeshedding does not help anyone. At best it just
> tightens nerves and breaks our group. Obviously if there is “you had ONE
> job” kind of situations or there is relatively high amount of errors
> combined with something serious it’s reasonable to ask fix the typos on
> the way as well. The reason being need to increase your statistics,
> personal perfectionist nature or actually I do not care what; just stop
> or go and do it somewhere else.
> Love and pink ponies,
> -Erno
> [1] www.urbandictionary.com/define.php?term=nitpicking
> <http://www.urbandictionary.com/define.php?term=nitpicking>
> [2] http://bikeshed.com
> [3] http://en.wiktionary.org/wiki/bikeshedding
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

More information about the OpenStack-dev mailing list