Open Stack

We’ve had this same problem, too, and I’d agree it should fail the Puppet run rather than just passing.  Would you mind writing up a bug report for this at https://launchpad.net/puppet-openstacklib ?

I have this on my list of stuff to fix when we go to Kilo (soon), so if somebody else doesn’t fix it, then I will.

Thanks!


From: <Black>, Matthew
Reply-To: "puppet-openstack at puppetlabs.com<mailto:puppet-openstack at puppetlabs.com>"
Date: Wednesday, June 17, 2015 at 12:54 PM
To: "puppet-openstack at puppetlabs.com<mailto:puppet-openstack at puppetlabs.com>"
Subject: duplicate keystone endpoints

I was digging around in the icehouse puppet code and I found what I believe is the cause of a duplicate endpoint creation during a short network disruption. In my environments the keystone servers do not reside in the same network as the regions. It looks like the puppet code fails the first request, sleeps 10 seconds, tries again and if that fails it then returns with a nil. The code then returns an empty array to the provider which then is assumed to mean that the endpoint does not exist. If the network blip is over by that point it will attempt to create the endpoint and thus a duplicate endpoint in the catalog.

https://github.com/openstack/puppet-keystone/blob/stable/icehouse/lib/puppet/provider/keystone.rb#L139

https://github.com/openstack/puppet-keystone/blob/stable/icehouse/lib/puppet/provider/keystone.rb#L83-L88


Looking at the juno code, which it is using the openstacklib, the issue still exists but in a slightly different fashion.

https://github.com/openstack/puppet-openstacklib/blob/master/lib/puppet/provider/openstack.rb#L55-L66

I believe this should be changed that instead of a breaking out of the loop it should throw an exception.

--


To unsubscribe from this group and stop receiving emails from it, send an email to puppet-openstack+unsubscribe at puppetlabs.com<mailto:puppet-openstack+unsubscribe at puppetlabs.com>.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150617/90d9b770/attachment.html>