Open Stack

On 06/08/2015 12:31 PM, Colleen Murphy wrote:
> 
> 
> On Sun, Jun 7, 2015 at 11:48 PM, Yanis Guenane <yguenane at redhat.com
> <mailto:yguenane at redhat.com>> wrote:
> 
> 
> 
>     On 06/03/2015 02:32 PM, Martin Mágr wrote:
>     >
>     > On 06/02/2015 07:05 PM, Mathieu Gagné wrote:
>     >> On 2015-06-02 12:41 PM, Yanis Guenane wrote:
>     >>> The openstacklib::db::sync[2] is currently only a wrapper around an
>     >>> exec
>     >>> that does the actual db sync, this allow to make any modification to
>     >>> the
>     >>> exec into a single place. The main advantage IMO is that a
>     contributor
>     >>> is provided with the same experience as it is not the case today
>     across
>     >>> all modules.
>     >>>
>     >> The amount of possible change to an exec resource is very
>     limited. [1] I
>     >> don't see a value in this change which outweighs the code churn and
>     >> review load needed to put it in place. Unless we have real use
>     cases or
>     >> outrageously genius feature to add to it, I'm not in favor of this
>     >> change.
>     >>
>     >> Furthermore, any change to the public interface of
>     >> openstacklib::db::sync would require changes across all our modules
>     >> anyway to benefit from this latest hypothetical feature. I think
>     we are
>     >> starting to nitpick over as little "generic" code we could
>     possibly find
>     >> to put in openstacklib.
>     >>
>     >> [1] https://docs.puppetlabs.com/references/latest/type.html#exec
>     >>
>     >
>     > Wearing my consistency hat I must say I like this change. On the other
>     > hand I agree with Mathieu that delegating single resource from several
>     > modules to single module is necessary in this case.
>     >
>     > Regards,
>     > Martin
> 
>     Mathieu, Martin, thank you for replying.
> 
>     For the wrapper around exec usefulness I understand your concerns.
>     On a note I was trying to follow the current use of openstacklib.
> 
>     If we look at openstacklib::db::postgresql[1] or
>     openstackib::db::mysql[2] they are simple wrapper around
>     puppet resources with no extra logic, but a common resource across all
>     modules.
> 
> The openstacklib::db::mysql resource is a wrapper around a couple of
> resources and contains logic around choosing an allowed hosts lists.

I think it's worth to add the exec logic in this wrapper, which is
Yanis's goal.

We might want some consistency between our modules on this part, so I
vote for solution #3 and agree on a common way to exec db sync.

> The openstacklib::db::postgresql is largely useless but makes the
> database interface consistent with mysql.

Why is it useless?

> 
> Colleen
> 
> 
>     Also, to move forward on this topic I will submit to a vote one of the
>     three propositions during our next meeting
> 
>      1. Abandon this change
>      2. Move everything to X::db::sync, but just run the exec there, no
>     openstacklib::db::sync
>      3. Move forward with current implementation
> 
>     Thanks again for the feedbacks,
> 
>     [1]
>     https://github.com/stackforge/puppet-openstacklib/blob/master/manifests/db/postgresql.pp
>     [2]
>     https://github.com/stackforge/puppet-openstacklib/blob/master/manifests/db/mysql.pp
> 
>     --
>     Yanis Guenane
> 
>     __________________________________________________________________________
>     OpenStack Development Mailing List (not for usage questions)
>     Unsubscribe:
>     OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>     <http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe>
>     http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> 
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 

-- 
Emilien Macchi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150609/8b924ea5/attachment.pgp>