[openstack-dev] [puppet] Change abandonment policy

Cody Herriges cody at puppetlabs.com
Wed Jun 3 05:45:55 UTC 2015


Colleen Murphy wrote:
<snip>
> 
> 3) Manually abandon after N months/weeks changes that have a -1 that was
> never responded to
> 
> ```
> If a change is submitted and given a -1, and subsequently the author
> becomes unresponsive for a few weeks, reviewers should leave reminder
> comments on the review or attempt to contact the original author via IRC
> or email. If the change is easy to fix, anyone should feel welcome to
> check out the change and resubmit it using the same change ID to
> preserve original authorship. If the author is unresponsive for at least
> 3 months and no one else takes over the patch, core reviewers can
> abandon the patch, leaving a detailed note about how the change can be
> restored.
> 
> If a change is submitted and given a -2, or it otherwise becomes clear
> that the change can not make it in (for example, if an alternate change
> was chosen to solve the problem), and the author has been unresponsive
> for at least 3 months, a core reviewer should abandon the change.
> ```
> 
> Core reviewers can click the abandon button on changes that no one has
> shown an interest in in N months/weeks, leaving a message about how to
> restore the change if the author wants to come back to it. Puppet Labs
> does this for its module pull requests, setting N at 1 month.
> 

+1

> 
> Option 3 leaves the possibility that a change that is mostly good
> becomes abandoned, making it harder for someone to find and restore it.
> 

In my opinion this will happen very infrequently.

-- 
Cody

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 931 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150602/72666d13/attachment.pgp>


More information about the OpenStack-dev mailing list