[openstack-dev] [murano] eslint cleanup
krotscheck at gmail.com
Tue Jul 28 14:37:52 UTC 2015
Well, the reasons those rules are deactivated is because they simply had no
equivalent in the previous tool, and we didn't want to force the Horizon
team to suddenly take on a far more aggressive style correction job than
they'd signed up for. Once their job goes green, I'm going to start
updating those rules one by one to slowly tighten the rules set.
With that in mind though: You can always extend the openstack rules and add
your own additional restrictions. So: Best of both worlds :), just make
sure you keep track of what's coming in from upstream.
On Tue, Jul 28, 2015 at 3:58 AM Kirill Zaitsev <kzaitsev at mirantis.com>
> Thanks Michael,
> I’m actually watching this process closely, and considering switching to
> these rules, as soon as the job goes green. =)
> The upside of not doing so is that, since our (murano) js code base is
> significantly smaller than that of horizon — we can impose slightly
> stricter rule set, than horizon currently does. But switching to it
> completely is something, that I do consider and it is on the roadmap =)
> Kirill Zaitsev
> Murano team
> Software Engineer
> Mirantis, Inc
> On 28 Jul 2015 at 03:00:40, Michael Krotscheck (krotscheck at gmail.com)
> FYI, those rules have been moved into OpenStack under the QA program.
> I'm currently working on getting npm publish jobs to function so we can
> release those rules as well.
> On Mon, Jul 27, 2015 at 4:13 PM Kirill Zaitsev <kzaitsev at mirantis.com>
>> Since there was some interest in my side activity (which is described
>> in https://blueprints.launchpad.net/murano/+spec/add-js-lint-jobs) I’ve
>> created an etherpad with files, that are yet to be cleaned up.
>> Here is the link https://etherpad.openstack.org/p/murano-escleanup
>> So I suggest, that if you’re willing to help — add yourself in front of
>> the file you’d like to cleanup so that we would not do the same job twice.
>> When adding rule configs I try to refer to
>> (I’m considering switching to it completely, but that is a story for a
>> different letter =))
>> Kirill Zaitsev
>> Murano team
>> Software Engineer
>> Mirantis, Inc
>> OpenStack Development Mailing List (not for usage questions)
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev