Open Stack

Colleagues,
it sounds like we need to complete what was requested by Julia here (and it
would take about a day as I understand), plus Andrey's request (which seems
to be very important for partner story and flexibility), plus additional
pieces which turned into bugs [1].

I'd like to hear opinion from fuel-web cores on this. I don't think we can
do all of what is requested.

[1] https://bugs.launchpad.net/fuel/+bugs?field.tag=feature-node-labels-cli

On Thu, Jul 23, 2015 at 6:13 PM Andrey Danin <adanin at mirantis.com> wrote:

> Hi, folks.
>
> I understand it may be not a good time but I want to make a proposal
> regarding this feature.
> The feature may be extremely useful for plugin developers if these labels
> would be serialized into astute.yaml. They may be used by plugin tasks to
> do node-specific modifications. Let me provide some examples:
> * For Xen integration we need to provide unique Xen Server credentials for
> each Compute node. But with current architecture we don't have any
> customizable per-node parameters.
> * It may be possible to use special labels to override global values (i.e.
> libvirt_type, thus implementing BP
> https://blueprints.launchpad.net/fuel/+spec/auto-virt-type).
> * Another case may be the fencing. A user may put IPMI credentials into
> labels.
> And there are more cases like that.
>
> Despite the original spec doesn't have this idea I propose to implement
> that. Moreover, I've already did it. Here are my two commits with a spec
> update [0] and an implementation[1]. They are pretty simple.
>
> [0] https://review.openstack.org/#/c/205105/
> [1] https://review.openstack.org/#/c/205113/
>
>
> Please grant FFE to this feature with my additions till tomorrow evening.
>
> On Thu, Jul 23, 2015 at 10:05 PM, Julia Aranovich <jkirnosova at mirantis.com
> > wrote:
>
>>
>> Mike, thanks for the important points you've provided.
>>
>> My main argument for this FFE is the following: we've already got a
>> confirmation from SME for this patch. But also got some not critical
>> comments at the last minute before we were going to merge it and have to
>> handle it now. But it looks that these comments don't block the feature and
>> we can fix it after merging a base patch.
>>
>> We tested the patch and it matches an acceptance criteria for the feature
>> with some not critical known issues that already converted to launchpad
>> tickets.
>>
>> I believe we can land it in master tomorrow with +1 from SME.
>>
>> BTW, I see no intersection in reviewers with this patch
>> https://review.openstack.org/#/c/204321/.
>>
>> Thank you,
>> Julia
>>
>>
>> On Thu, Jul 23, 2015 at 9:40 PM Mike Scherbakov <mscherbakov at mirantis.com>
>> wrote:
>>
>>> -1
>>> My concerns are the following:
>>>
>>>    1. This feature is of a High priority, not Essential [1]
>>>    2. We already had to give exception for flexible networking CLI part
>>>    [2], as it is essential one. So basically that means we have a conflict of
>>>    focus for SMEs in the area.
>>>    3. Just by working on this, we don't spend time on bugs. Which
>>>    increases risk of delivering on time with expected level of quality
>>>
>>> +390, -35 LOC also scare me a little bit, it's not a tiny change.
>>>
>>> One of the possible workarounds can be, if we deliver this patch after
>>> HCF, and have an updated package of client. If someone want it in
>>> experimental mode, then the one could update client package and have this
>>> functionality.
>>>
>>> If you convince me though that it can be finished by end of the week
>>> with only code reviews from SMEs (and only after flexible networking part
>>> is done), only after it I can change my mind.
>>>
>>> [1] https://blueprints.launchpad.net/fuel/+spec/node-custom-attributes
>>> [2] https://review.openstack.org/#/c/204321/
>>>
>>> On Thu, Jul 23, 2015 at 10:53 AM Sebastian Kalinowski <
>>> skalinowski at mirantis.com> wrote:
>>>
>>>> +1 for this FFE as it's important to have this functionality covered in
>>>> CLI
>>>>
>>>> 2015-07-23 19:46 GMT+02:00 Igor Kalnitsky <ikalnitsky at mirantis.com>:
>>>>
>>>>> Hi Julia,
>>>>>
>>>>> I'm ok with FF exception for CLI part. I don't think it can somehow
>>>>> decrease product quality, so as a core I'll help to land it.
>>>>>
>>>>> Thanks,
>>>>> Igor
>>>>>
>>>>> On Thu, Jul 23, 2015 at 7:50 PM, Julia Aranovich
>>>>> <jkirnosova at mirantis.com> wrote:
>>>>> > Team,
>>>>> >
>>>>> > I would like to request an exception from the Feature Freeze for CLI
>>>>> changes
>>>>> > of working with custom node labels added to fuelclient (fuel2) [1].
>>>>> UI and
>>>>> > Nailgun parts of the story are already merged [2].
>>>>> >
>>>>> > There CLI request is being actively reviewed, the base flow is
>>>>> accepted.
>>>>> > There are minimal risks here since the changes added to fuel2
>>>>> version.
>>>>> >
>>>>> > Please, respond if you have any questions or concerns related to this
>>>>> > request.
>>>>> >
>>>>> > Thanks in advance,
>>>>> > Julia
>>>>> >
>>>>> > [1] https://review.openstack.org/#/c/204524/
>>>>> > [2] https://review.openstack.org/#/c/201472/
>>>>> >
>>>>> >
>>>>> __________________________________________________________________________
>>>>> > OpenStack Development Mailing List (not for usage questions)
>>>>> > Unsubscribe:
>>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>>> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>> >
>>>>>
>>>>>
>>>>> __________________________________________________________________________
>>>>> OpenStack Development Mailing List (not for usage questions)
>>>>> Unsubscribe:
>>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>>
>>>>
>>>>
>>>> __________________________________________________________________________
>>>> OpenStack Development Mailing List (not for usage questions)
>>>> Unsubscribe:
>>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>>
>>> --
>>> Mike Scherbakov
>>> #mihgen
>>>
>>> __________________________________________________________________________
>>> OpenStack Development Mailing List (not for usage questions)
>>> Unsubscribe:
>>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>>
>
>
> --
> Andrey Danin
> adanin at mirantis.com
> skype: gcon.monolake
>  __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-- 
Mike Scherbakov
#mihgen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150724/edfff7a6/attachment.html>