<div dir="ltr">Colleagues,<div>it sounds like we need to complete what was requested by Julia here (and it would take about a day as I understand), plus Andrey's request (which seems to be very important for partner story and flexibility), plus additional pieces which turned into bugs [1].</div><div><br></div><div>I'd like to hear opinion from fuel-web cores on this. I don't think we can do all of what is requested.</div><div><br></div><div>[1] <span style="line-height:1.5;font-size:13.1999998092651px"><a href="https://bugs.launchpad.net/fuel/+bugs?field.tag=feature-node-labels-cli">https://bugs.launchpad.net/fuel/+bugs?field.tag=feature-node-labels-cli</a></span></div>
</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 23, 2015 at 6:13 PM Andrey Danin <<a href="mailto:adanin@mirantis.com">adanin@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div><div>Hi, folks.<br><br></div>I understand it may be not a good time but I want to make a proposal regarding this feature.<br></div>The feature may be extremely useful for plugin developers if these labels would be serialized into astute.yaml. They may be used by plugin tasks to do node-specific modifications. Let me provide some examples:<br>* For Xen integration we need to provide unique Xen Server credentials for each Compute node. But with current architecture we don't have any customizable per-node parameters.<br>* It may be possible to use special labels to override global values (i.e. libvirt_type, thus implementing BP <a href="https://blueprints.launchpad.net/fuel/+spec/auto-virt-type" target="_blank">https://blueprints.launchpad.net/fuel/+spec/auto-virt-type</a>).<br>* Another case may be the fencing. A user may put IPMI credentials into labels.<br></div><div>And there are more cases like that.<br></div><div><br></div><div>Despite the original spec doesn't have this idea I propose to implement that. Moreover, I've already did it. Here are my two commits with a spec update [0] and an implementation[1]. They are pretty simple.<br><br>[0] <a href="https://review.openstack.org/#/c/205105/" target="_blank">https://review.openstack.org/#/c/205105/</a><br>[1] <a href="https://review.openstack.org/#/c/205113/" target="_blank">https://review.openstack.org/#/c/205113/</a><br><br><br></div><div>Please grant FFE to this feature with my additions till tomorrow evening.<br></div></div><div class="gmail_extra"></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul 23, 2015 at 10:05 PM, Julia Aranovich <span dir="ltr"><<a href="mailto:jkirnosova@mirantis.com" target="_blank">jkirnosova@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div>Mike, thanks for the important points you've provided.</div><div><br></div><div>My main argument for this FFE is the following: we've already got a confirmation from SME for this patch. But also got some not critical comments at the last minute before we were going to merge it and have to handle it now. But it looks that these comments don't block the feature and we can fix it after merging a base patch.</div><div><br></div><div>We tested the patch and it matches an acceptance criteria for the feature with some not critical known issues that already converted to launchpad tickets.</div><div><br></div><div>I believe we can land it in master tomorrow with +1 from SME.</div><div><br></div><div>BTW, I see no intersection in reviewers with this patch <a href="https://review.openstack.org/#/c/204321/" target="_blank">https://review.openstack.org/#/c/204321/</a>.</div><div><br></div><div>Thank you,<br>Julia</div><div><div><div><br></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 23, 2015 at 9:40 PM Mike Scherbakov <<a href="mailto:mscherbakov@mirantis.com" target="_blank">mscherbakov@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">-1 <div>My concerns are the following:</div><div><ol><li>This feature is of a High priority, not Essential [1]</li><li>We already had to give exception for flexible networking CLI part [2], as it is essential one. So basically that means we have a conflict of focus for SMEs in the area.</li><li>Just by working on this, we don't spend time on bugs. Which increases risk of delivering on time with expected level of quality</li></ol><div>+390, -35 LOC also scare me a little bit, it's not a tiny change.</div></div><div><br></div><div>One of the possible workarounds can be, if we deliver this patch after HCF, and have an updated package of client. If someone want it in experimental mode, then the one could update client package and have this functionality.</div><div><br></div><div>If you convince me though that it can be finished by end of the week with only code reviews from SMEs (and only after flexible networking part is done), only after it I can change my mind.</div><div><br></div><div>[1] <a href="https://blueprints.launchpad.net/fuel/+spec/node-custom-attributes" target="_blank">https://blueprints.launchpad.net/fuel/+spec/node-custom-attributes</a></div><div>[2] <a href="https://review.openstack.org/#/c/204321/" target="_blank">https://review.openstack.org/#/c/204321/</a></div></div><div dir="ltr"><br><div class="gmail_quote"><div dir="ltr">On Thu, Jul 23, 2015 at 10:53 AM Sebastian Kalinowski <<a href="mailto:skalinowski@mirantis.com" target="_blank">skalinowski@mirantis.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">+1 for this FFE as it's important to have this functionality covered in CLI<br></div><div class="gmail_extra"><br><div class="gmail_quote">2015-07-23 19:46 GMT+02:00 Igor Kalnitsky <span dir="ltr"><<a href="mailto:ikalnitsky@mirantis.com" target="_blank">ikalnitsky@mirantis.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Julia,<br>
<br>
I'm ok with FF exception for CLI part. I don't think it can somehow<br>
decrease product quality, so as a core I'll help to land it.<br>
<br>
Thanks,<br>
Igor<br>
<span><br>
On Thu, Jul 23, 2015 at 7:50 PM, Julia Aranovich<br>
<<a href="mailto:jkirnosova@mirantis.com" target="_blank">jkirnosova@mirantis.com</a>> wrote:<br>
> Team,<br>
><br>
> I would like to request an exception from the Feature Freeze for CLI changes<br>
> of working with custom node labels added to fuelclient (fuel2) [1]. UI and<br>
> Nailgun parts of the story are already merged [2].<br>
><br>
> There CLI request is being actively reviewed, the base flow is accepted.<br>
> There are minimal risks here since the changes added to fuel2 version.<br>
><br>
> Please, respond if you have any questions or concerns related to this<br>
> request.<br>
><br>
> Thanks in advance,<br>
> Julia<br>
><br>
> [1] <a href="https://review.openstack.org/#/c/204524/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/204524/</a><br>
</span>> [2] <a href="https://review.openstack.org/#/c/201472/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/201472/</a><br>
><br>
> __________________________________________________________________________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
><br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div><div dir="ltr">-- <br></div><div dir="ltr">Mike Scherbakov<br>#mihgen</div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div></div></div>
<br>__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><br></div><div class="gmail_extra">-- <br><div>Andrey Danin<br><a href="mailto:adanin@mirantis.com" target="_blank">adanin@mirantis.com</a><br>skype: gcon.monolake<br></div>
</div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><div dir="ltr">-- <br></div><div dir="ltr">Mike Scherbakov<br>#mihgen</div>