[openstack-dev] [Neutron] - breaking changes for plugins/drivers

Kyle Mestery mestery at mestery.com
Wed Jul 1 13:09:54 UTC 2015


On Wed, Jul 1, 2015 at 5:49 AM, Kevin Benton <blak111 at gmail.com> wrote:

> >For the second one, I think we made it clear before that no plugins must
> rely on neutron.openstack.* contents.
>
> Where was this made clear? I didn't know about this until it broke and I'm
> a very frequent contributor and reviewer, which is the core of my
> complaint. The updated wiki is helpful, but doing it after-the-fact only
> helps when people try to figure out why they can't make changes to their
> repos.
>
>
I agree, and I'd also like to mention that it would be good to move this
type of documentation in-tree so it can be autogenerated rather than using
the wiki.


> In that patch there were 3 in-tree third party plugins that had to be
> updated. That should have given a hint that it was likely to break other
> plugins as well. The other annoying lesson from that is that
> plugins/drivers still in tree are getting better treatment than the ones
> that went through the split process.
>
>
Also agree. The current plan of record is that plugins/drivers which have
not started to decompose will be marked as deprecated in Liberty, and we'll
remove them in Mxx. I hope Henry can update his "Phase 2 Decomp" devref [1]
to indicate this.

[1] https://review.openstack.org/#/c/187267/

We need to be much more diligent about announcing these things ahead of
> time or we need to be clear that Neutron is completely unstable as a
> framework and third party drivers should basically never import anything
> from the neutron namespace.
>
>
We're working on that. The decomp of the reference plugin will help this
situation because you won't be able to pass the gate if you break these
types of things, and that will give patch authors time to notify everyone
else of breaking changes, or even just submit patches to the other
repositories.


> On Tue, Jun 30, 2015 at 11:58 PM, Ihar Hrachyshka <ihrachys at redhat.com>
> wrote:
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA256
>>
>> On 07/01/2015 08:22 AM, Kevin Benton wrote:
>> > Hi,
>> >
>> > We have had at least two breaking changes merge this week for
>> > out-of-tree drivers/plugins. These are just the two I noticed that
>> > broke the Big Switch CI (the one I keep an eye on since I had set
>> > it up):
>> >
>> > 1. Removed test_lib that changes config files.
>> > https://review.openstack.org/#/c/196583/ 2. Removed the loopingcall
>> > common util with no deprecation cycle or announcement.
>> > https://review.openstack.org/#/c/192999/
>> >
>> > I proposed a revert for 1 that merged, but I don't particularly
>> > want to keep fighting this. What is our current policy on this?
>> > Just change whatever we want and tell plugin maintainers this is
>> > just the way things work?
>> >
>>
>> For the first one, the revert is justified.
>>
>> For the second one, I think we made it clear before that no plugins
>> must rely on neutron.openstack.* contents.
>>
>> Now I've made it mentioned at:
>> https://wiki.openstack.org/wiki/Neutron/LibraryAPIBreakage
>>
>> If your plugin is using any of neutron.openstack.* contents, just stop
>> doing it. It's going to break.
>>
>> Ihar
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v2
>>
>> iQEcBAEBCAAGBQJVk4+AAAoJEC5aWaUY1u57OE8IAKDqKudi5zOUxRPc4Elzsdw4
>> mASF5Mtguj5q9OUpYIyeOkbsIKmOwop4tbGjz52L+OZ8aLq1XptpKLUuX6mBL3lS
>> m0/DtD2RlBRTmiO/kyBxeqJbsj7nZU9eoiDJ88gN51IetN1kIR09rAbmdkoduhK2
>> FIrFLJhhuVqmb8S377cbSgJ46kC1DeDa2xhtFWB39iIKO3ZTwO7ia5KRipTSTyNV
>> 4ngB0+d8EgMfmsKj4Bd7/btkg5rI+o4qNgd4L1Ncd1BQzPiOzzeeGo0lAe86Kf7z
>> KUH2Sw6n6mIUZJSGzDP4cigGqSsilBaurryK90G/Go1q7BEMRFVyrGHObnMBZTw=
>> =qSnW
>> -----END PGP SIGNATURE-----
>>
>> __________________________________________________________________________
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe:
>> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>
>
>
>
> --
> Kevin Benton
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150701/297a9cf9/attachment.html>


More information about the OpenStack-dev mailing list