[openstack-dev] [neutron] Question on functional tests

Numan Siddique numan.siddique at enovance.com
Tue Jan 20 18:20:11 UTC 2015


Hello,

I am working on a bug [1] on neutron vpnaas and submitted the patch here 
[2].

The test code to test the fix does the following
     - creates a namespace
     - creates a veth pair and add one interface into the namespace
     - configures the interface with an ip address and
     - adds a default gateway
     - and of course tests the code.

This test code only tests a specific function 
(OpenSwanProcess._get_nexthop())

Reviewers of this patch are not clear if this should be part of 
functional tests or unit tests.
Can unit tests create linux namespaces, interfaces etc or it falls under 
functional tests?

Please let me know your thoughts on this.

[1] - https://bugs.launchpad.net/neutron/+bug/1405413
[2] - https://review.openstack.org/#/c/145005/5


Regards
Numan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150120/fe5e77bb/attachment.html>


More information about the OpenStack-dev mailing list