<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font face="monospace">Hello,<br>
<br>
I am working on a bug [1] on neutron vpnaas and submitted the
patch here [2].<br>
<br>
The test code to test the fix does the following<br>
- creates a namespace<br>
- creates a veth pair and add one interface into the namespace<br>
- configures the interface with an ip address and<br>
- adds a default gateway<br>
- and of course tests the code.<br>
<br>
This test code only tests a specific function (</font><font
face="monospace">
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
<span style="color: rgb(102, 0, 102); font-family: monospace;
font-size: 12px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: auto; text-align: start; text-indent: 0px;
text-transform: none; white-space: pre; widows: auto;
word-spacing: 0px; -webkit-text-stroke-width: 0px; display:
inline !important; float: none; background-color: rgb(255, 255,
255);">OpenSwanProcess.</span>_get_nexthop())<br>
</font><font face="monospace"><font face="monospace"><br>
Reviewers of this patch are not clear if this should be part of
functional tests or unit tests.<br>
</font>Can unit tests create linux namespaces, interfaces etc or
it falls under functional tests?<br>
<br>
Please let me know your thoughts on this.<br>
<br>
[1] - <a class="moz-txt-link-freetext" href="https://bugs.launchpad.net/neutron/+bug/1405413">https://bugs.launchpad.net/neutron/+bug/1405413</a><br>
[2] - <a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/145005/5">https://review.openstack.org/#/c/145005/5</a><br>
<br>
<br>
Regards<br>
Numan<br>
<br>
</font>
</body>
</html>