Open Stack

Thanks for the insight into lockutils-wrapper usage Ihar.  I had worked on
getting the coverage target for VPNaaS repo working, and then have been
working on a coverage target for functional testing. As part of that, I
pulled the use of lockutils-wrapper.

If you can review it, I'd appreciate it very much:
https://review.openstack.org/#/c/155889/2

I was thinking of doing this same coverage testing for FWaaS and LBaaS, if
you want me to remove lockutils-wrapper there too, let me know, as I was
planning on working on these today...

Regards,
PCM


PCM (Paul Michali)

IRC............ pc_m (irc.freenode.com)
Twitter....... @pmichali


On Mon, Feb 16, 2015 at 8:16 AM, Ihar Hrachyshka <ihrachys at redhat.com>
wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 02/13/2015 11:13 PM, Paul Michali wrote:
> > I see that in tox.ini, several commands have lockutils-wrapper
> > prefix on them in the neutron-vpnaas repo. Seems like this was
> > added as part of commit 88e2d801 for Migration to
> > oslo.concurrency.
>
> Those would be interesting for unit tests only. And now that neutron
> BaseTestCase uses proper fixture [1], we can just remove the wrapper
> call from all *aas repos.
>
> That was actually one of the things I was going to do as a oslo
> liaison during Kilo [2] (see the 1st entry in the todo list.) But if
> you want to go with this before I reach this cleanup, I will be glad
> to review the changes. :)
>
> [1]:
>
> http://git.openstack.org/cgit/openstack/neutron/tree/neutron/tests/base.py#n89
> [2]:
> http://lists.openstack.org/pipermail/openstack-dev/2015-January/054753.html
>
> /Ihar
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1
>
> iQEcBAEBAgAGBQJU4e21AAoJEC5aWaUY1u57zKcH/iZ3SFi3BmyYaEwch5jipbzw
> Byxn2QxyjRNcQ6m/dr6ihpvXS2bIo75mrNajc+mdnKTqAdXebceSQRPAw4EX3c9r
> qtlaGzSrBqmSiyl/YnbqUiUf2zcXpFIpiTJswbdhv10P5Gi/Q64m6d+ipQsIUaMP
> 4sY/0sjAV5Gn9cpkBZn9LY1/CrWnP7eqFMBYvFTsyEpGHdgJ4heAx2dLCqY2DE9H
> bVFexZK1yMqLzEIwmHtzSyifcFZkC39fa6bsxCVlLkbfU7+KC56FOOHARsjf+grd
> ReQuGH4QIS0aTMkrd7qmJRkaK7BudkX1yfOY68jsYSwrpKoia7pMZ+tbPosfUbk=
> =+HKf
> -----END PGP SIGNATURE-----
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20150217/3b38734f/attachment.html>