[openstack-dev] [tripleo] Pin some puppet dependencies on git clone
Jaume Devesa
devvesa at gmail.com
Tue Dec 15 16:59:15 UTC 2015
I suggest then to pin the dependencies from [1] to below.
Couldn't be posible to just clone the openstack/puppet-* ones
and then use some tool to install the dependencies from them, some
kind of
pip install -r requirements.txt
but adapted for Puppet? Does this tool exist?
[1]:
https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile#L111
On 15 December 2015 at 17:46, Emilien Macchi <emilien at redhat.com> wrote:
> For information, Puppet OpenStack CI is consistent for unit & functional
> tests, we use a single (versionned) Puppetfile:
>
> https://github.com/openstack/puppet-openstack-integration/blob/master/Puppetfile
>
> TripleO folks might want to have a look at this to follow the
> dependencies actually supported by upstream OR if you prefer surfing on
> the edge and risk to break CI every morning.
>
> Let me know if you're interested to support that in TripleO Puppet
> elements, I can help with that.
>
> On 12/14/2015 02:25 PM, Dan Prince wrote:
> > On Fri, 2015-12-11 at 21:50 +0100, Jaume Devesa wrote:
> >> Hi all,
> >>
> >> Today TripleO CI jobs failed because a new commit introduced on
> >> puppetlabs-mysql[1].
> >> Mr. Jiri Stransky solved it as a temporally fix by pinning the puppet
> >> module clone to a previous
> >> commit in the tripleo-common project[2].
> >>
> >> source-repositories puppet element[3] allows you to pin the puppet
> >> module clone as well by
> >> adding a reference commit in the source-repository-<element-name>
> >> file. In this case,
> >> I am talking about the source-repository-puppet-modules[4].
> >>
> >> I know you TripleO guys are brave people that live dangerously in the
> >> cutting edge, but I think
> >> the dependencies to puppet modules not managed by the OpenStack
> >> community should be
> >> pinned to last repo tag for the sake of stability.
> >>
> >> What do you think?
> >
> > I've previously considered added a stable puppet modules element for
> > just this case:
> >
> > https://review.openstack.org/#/c/184844/
> >
> > Using stable branches of things like MySQL, Rabbit, etc might make
> > sense. However I would want to consider following what the upstream
> > Puppet community does as well specifically because we do want to
> > continue using upstream openstack/puppet-* modules as well. At least
> > for our upstream CI.
> >
> > We also want to make sure our stable TripleO jobs use the stable
> > branches of openstack/puppet-* so we might need to be careful about
> > pinning those things too.
> >
> > Dan
> >
> >
> >> I can take care of this.
> >>
> >> [1]: https://github.com/puppetlabs/puppetlabs-mysql/commit/bdf4d0f52d
> >> fc244d10bbd5b67efb791a39520ed2
> >> [2]: https://review.openstack.org/#/c/256572/
> >> [3]: https://github.com/openstack/diskimage-builder/tree/master/eleme
> >> nts/source-repositories
> >> [4]: https://github.com/openstack/tripleo-puppet-elements/blob/master
> >> /elements/puppet-modules/source-repository-puppet-modules
> >>
> >> --
> >> Jaume Devesa
> >> Software Engineer at Midokura
> >> _____________________________________________________________________
> >> _____
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubs
> >> cribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> >
> __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe:
> OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> --
> Emilien Macchi
>
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
--
Jaume Devesa
Software Engineer at Midokura
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20151215/2802db57/attachment.html>
More information about the OpenStack-dev
mailing list